MarketSquare / robotframework-angularjs

An AngularJS and Angular extension to Robotframework's SeleniumLibrary
Apache License 2.0
34 stars 20 forks source link

Cannot import angularjs library when using the latest version of seleniumlibrary #19

Closed chaussen closed 6 years ago

chaussen commented 7 years ago

versions: robotframework==3.0.2 robotframework-angularjs==0.0.6 robotframework-selenium2library==3.0.0b1

got error

Importing test library 'AngularJSLibrary' failed: ImportError: No module named locators Traceback (most recent call last): File "C:\Python27\lib\site-packages\AngularJSLibrary\__init__.py", line 6, in <module> from Selenium2Library.locators import ElementFinder

downgrade selenium2library can fix it.

emanlove commented 6 years ago

@chaussen I am starting to look at this now.

emanlove commented 6 years ago

I am going to look at the latest published (to PyPI) version of the SeleniumLibrary which is as of today 3.0.1. So with the current version of robotframework-angularjs, that is 0.0.6, will work with robotframework-selenium2library==1.8.0 and I will branch off to support robotframework-seleniumlibrary==3.0.1.

In house I have not fully upgraded to the newer SeleniumLibrary so I will see if I can create multiple releases depending on the version of the Selenium2Library/SeleniumLibrary.

chaussen commented 6 years ago

@emanlove thanks. as a workaround i am currently only using the wait for angular keyword by copying the javascript from the source file and using wait for condition keyword from seleniumlibrary with it.

emanlove commented 6 years ago

@chaussen I have started a new branch, seleniumlibrary-v3.x, which has some changes Selenium2Library/robotframework-angularjs@2bde218125d96c4debb08b77c7bc12b7bc81b8c5 that make the AngularJSLibrary compatible with the newest SeleniumLibrary.

I have not tested with SeleniumLibrary versions prior to 3.0.1; of which I will admit there are very few and mostly release candidates and don't plan on testing those. I have also been tossing around the idea of being able to handle, at least in the short short term both SeleniumLibrary (v3.0.1) and Selenium2Library (v3.0.0) so that it won't fail if you have either library v3.0.0+. Finally I am also thinking about making a release that supports both -1.8.0 and 3.0.0+ again for a short time. (My project and work is still working with 1.8.0).

carllp commented 6 years ago

@emanlove Tested the new branch (0.0.7) and still receiving import errors. Using Eclipse RED 0.8.2 and SeleniumLibrary 3.0.1 Screenshot below. Is the libspec file generated on import? Or is there something else I should be doing?

If you need more information, please let me know.

image

Thanks. This library is very much appreciated.

asief44 commented 6 years ago

@carllp, I'm also facing same issue. Is this issue is resolved for you?? Please confirm image

emanlove commented 6 years ago

@asief44 is it possible to get the fill text of the stacktrace for the error you are seeing?

emanlove commented 6 years ago

I believe this issue to be resolved within the 0.0.9 version of the AngularJSLibrary. If you are still experiencing this issue with the 0.0.9 release of AngularJSLibrary please re-open this issue.