MarketSquare / robotframework-aws

Custom Library for Robot Framework to interact with Amazon Cloud Services
MIT License
26 stars 21 forks source link

fix for key should not exist #20

Closed teaglebuilt closed 4 years ago

teaglebuilt commented 4 years ago

One thing I have thought of from this issue is taking the client error response into the exceptions class and dismantling the response object and formatted for the user.

The fix for this keyword is obvious and was something I obviously missed in a rush. I did not test it extensively. a robot test has been added, unit test is not complete.

teaglebuilt commented 4 years ago

your right, we need to make sure this library is compatible for both versions. As far as # noqa in s3. I believe i can get rid of that. We might need to open an issue to tighten up on linting and any other configurations that might be misconfigured.

ill update this pr

adrianyorke commented 4 years ago

Merged.