Add optional endpoint_url to s3 keywords

MarketSquare / robotframework-aws

Custom Library for Robot Framework to interact with Amazon Cloud Services

MIT License

26 stars 21 forks source link

Closed Jakob-em closed 4 years ago

Jakob-em commented 4 years ago

These changes make it possible to use an s3 mock implementaion like https://hub.docker.com/r/adobe/s3mock

Jakob-em commented 4 years ago

@teaglebuilt Would it be possbile to get this merged?

Jakob-em commented 4 years ago

@teaglebuilt Is there anything wrong with the PR? Could you please give me more information why this can't be merged?

teaglebuilt commented 4 years ago

@adrianyorke @Jakob-em is this ready to be merged?

Jakob-em commented 4 years ago

@teaglebuilt I added the region parameter back to keep the compatibility with existing scripts. Would be happy to get this merged 🙂

adrianyorke commented 4 years ago

Thanks for the PR and region fix @Jakob-em.

iampluque commented 3 years ago

@Jakob-em do you plan a release with this PR ?