MarketSquare / robotframework-browser

Robot Framework Browser library powered by Playwright.
Apache License 2.0
499 stars 105 forks source link

Add the kwarg timeout to Connect to Browser #3668

Open mardukbp opened 1 month ago

mardukbp commented 1 month ago

Is your feature request related to a problem? Please describe. When calling New Browser the kwarg "timeout" determines the time that Playwright waits for a selector to be resolved. The standard value is 30s. When connecting to a running browser with Connect to Browser there is no way to change this time interval.

Describe the solution you'd like Connect to Browser has a kwarg timeout.

Describe alternatives you've considered I tried setting the timeout to 1s with Set Browser Timeout but Playwright still waits 30s to resolve a selector.

Additional context Add any other context or screenshots about the feature request here.

aaltat commented 1 month ago

Sounds reasonable

@allcontributors please add @mardukbp for ideas.

allcontributors[bot] commented 1 month ago

@aaltat

@mardukbp already contributed before to ideas