MarketSquare / robotframework-seleniumlibrary-java

Java port of the Python based SeleniumLibrary for Robot Framework
Apache License 2.0
23 stars 16 forks source link

added webdrivermanager of io.github.bonigarcia library interaction #73

Closed YauheniPo closed 5 years ago

Hi-Fi commented 5 years ago

Thank you, this shows really interesting but I have to check code a bit more. Currently webdriver need is handled by Maven with https://github.com/Ardesco/selenium-standalone-server-plugin (that allows usage of local repos for stricter network access).

YauheniPo commented 5 years ago

I am using your framework for my test project and I updated and added some functions for my tests actions. https://github.com/YauheniPo/RobotFramework_GUI_Tests

YauheniPo commented 5 years ago

If I do not use my solution I have

Setup failed:
java.lang.IllegalStateException: The path to the driver executable must be set by the webdriver.chrome.driver system property; for more information, see https://github.com/SeleniumHQ/selenium/wiki/ChromeDriver. The latest version can be downloaded from http://chromedriver.storage.googleapis.com/index.html

What do you think?

Hi-Fi commented 5 years ago

As said, currently I'm using self in tests (and that way instructing others) to use Maven to handle the dependencies including Webdriver (https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/blob/develop/pom.xml#L202). That of course requires that things are running with Maven and not using stand-alone jar. For latter one your solution is fine, but I have to check at code side the implementation, and if the release with new keywords related to webdriver binaries should be released still with Selenium 3 or along with Selenium 4 (alpha) release.