search

MarketSquare / robotframework-seleniumlibrary-java

Java port of the Python based SeleniumLibrary for Robot Framework
Apache License 2.0
23 stars 16 forks source link

updated the following keywords so they correctly handle case sensitiv… #76

Closed ractoc closed 5 years ago

ractoc commented 5 years ago

Conform Issue #75 I have prepared this pull request.

updated the following keywords so they correctly handle case sensitivity conform the Python implementation

Element Should Contain Element Should Not Contain Element Text Should Be Element Text Should Not Be

ractoc commented 5 years ago

I'll check if I can implement the relevant changes you suggested above later today. More meetings first...

ractoc commented 5 years ago

@php-coder I think I got all of the issues sorted.

ractoc commented 5 years ago

I'm heading home now, I'll look into it more tomorrow if there are more findings

Hi-Fi commented 5 years ago

First of all thank you for the PR.

I think getText can return null, so there might be extra NPEs coming from (original) code, too. If those could be checked at the same time it would be nice. I think most of those would be bypassed by using StringUtils -methods instead of String's own ones.

ractoc commented 5 years ago

I did a quick check of the StringUtils methods. If either actual or text is null, those methods return false. So that should work nicely

ractoc commented 5 years ago

final commit, I hope...

php-coder commented 5 years ago

@ractoc Thank you, Mark!

If you aren't fully tired with that, you might want to squash 5 commits into single one (see https://davidwalsh.name/squash-commits-git).

ractoc commented 5 years ago

That should do it then... Now, if you set the compare to ignore whitespace changes, you should get only the actual changes