Added setFocusToElement to replace the Focus keyword

[ractoc]

Added the new Set Focus To Element keyword which replaces the Focus keyword. For backwards compatibility, the old Focus keyword has been left in there but has been marked as deprecated.

Also added the companion keyword Element Should Be Focused to detect if a given element has focus.

This PR doesn not need an immediate release.

[ractoc]

Added the new version of Get Element Attribute. This new version takes 2 parameters, one for hte locator and one for the actual attribute. I kept the old method, which is now almost empty and just forwards to the new method. I also marked the old method as deprecated.

This new method is something we do need sooner rather then later as it is required to make our code work both on Python and on Java with the same script.

[ractoc]

For some reason, Travis is failing. This just happens on the FireFox profile. The error I see is: Element is not clickable at point (311,447) because another element

obscures it.

No real idea what could be causing this though. My changes shouldn't have this effect as far as I can determine.

@YauheniPo, @Hi-Fi Maybe one of you guys could take a look at it? I'm guessing this is holding back any new release I might want

Hi-Fi commented 5 years ago

I tried to reproduce that error but wasn't successfull (so all tests were passing). I think this can be merged to develop.

ractoc commented 5 years ago

@Hi-Fi After some more testing on our end, we found a little problem with the getElementAttribute changes. It turns out RobotFramework can't handle overloading in the Java library, or we're doing something wrong. I had to remove the old method completely to get the new method to be excepted. Having them both in there gives some strange error.

Keyword 'SeleniumLibrary.Get Element Attribute' expected 1 argument, got 2.

Now I'm not quite sure how to keep this backwards compatible. But if the goal is to move everything towards being a 1-on-1 of the python version, We shouldn't need to keep the old one, as the python version also only has the two parameter version of the Get Element Attribute keyword.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[Hi-Fi]

I tried to reproduce that error but wasn't successfull (so all tests were passing). I think this can be merged to develop.

[ractoc]

@Hi-Fi After some more testing on our end, we found a little problem with the getElementAttribute changes. It turns out RobotFramework can't handle overloading in the Java library, or we're doing something wrong. I had to remove the old method completely to get the new method to be excepted. Having them both in there gives some strange error.

Keyword 'SeleniumLibrary.Get Element Attribute' expected 1 argument, got 2.

Now I'm not quite sure how to keep this backwards compatible. But if the goal is to move everything towards being a 1-on-1 of the python version, We shouldn't need to keep the old one, as the python version also only has the two parameter version of the Get Element Attribute keyword.