search

MarketSquare / robotframework-seleniumlibrary-java

Java port of the Python based SeleniumLibrary for Robot Framework
Apache License 2.0
23 stars 16 forks source link

Fix for Get Element Attribute overloading #83

Closed ractoc closed 5 years ago

ractoc commented 5 years ago

turns out it is not possible to work with overloaded methods when it comes to RF. So the old, 1 parameter, method had to be removed completely.

This also means a slightly different (uglier) way of getting the locator and attribute in there to keep everything backwards compatible.

The only way to get around using this uglier way is to break backwards compatibility though so this would seem the lesser of two evils for now.

ractoc commented 5 years ago

@Hi-Fi I kinda broke the thing with my last PR.... This should fix it.

Any idea when I can expect this fixed version?

Hi-Fi commented 5 years ago

There's separate annotation to overload methods within Java libraries. See e.g. addLocationStrategy at https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/blob/develop/src/main/java/com/github/markusbernhardt/seleniumlibrary/keywords/BrowserManagement.java#L128

ractoc commented 5 years ago

Cool, I'll drop this change then in favor of adding that one...

Hi-Fi commented 5 years ago

It would be nice if you also can add test for both old and new way-

On Tue, 30 Jul 2019 at 16:04, Mark Schrijver notifications@github.com wrote:

Closed #83 https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/pull/83.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/pull/83?email_source=notifications&email_token=AALOFBGTYPYK2VKEUNERDVTQCA36BA5CNFSM4IH36GEKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOSYX7EHY#event-2519724575, or mute the thread https://github.com/notifications/unsubscribe-auth/AALOFBDXXVVJNPSR6H5EI3TQCA36BANCNFSM4IH36GEA .