search

MarketSquare / robotframework-seleniumlibrary-java

Java port of the Python based SeleniumLibrary for Robot Framework
Apache License 2.0
23 stars 16 forks source link

"Table Footer Should Contain" should take into account <th> elements #88

Closed php-coder closed 4 years ago

php-coder commented 5 years ago

Table Footer Should Contain is always looking for <td> tags within <tfoot>:

https://github.com/Hi-Fi/robotframework-seleniumlibrary-java/blob/fed6f0e95b5cf5a365f8357a9976ec9ed7ff7e1e/src/main/java/com/github/markusbernhardt/seleniumlibrary/locators/TableElementFinder.java#L17

but it's valid to have <th> tags here also. Example: https://developer.mozilla.org/en-US/docs/Web/HTML/Element/tfoot

Can we have this keyword fixed to take into account <th> tags as well?

php-coder commented 5 years ago

I've submitted this to the upstream as well: https://github.com/robotframework/SeleniumLibrary/issues/1436