MarketSquare / webdrivermanager

Python module to facilitate downloading and deploying WebDriver binaries for Chrome, Firefox, Opera & Edge
https://pypi.org/project/webdrivermanager/
MIT License
100 stars 38 forks source link

Support Cygwin as platform (alias for Windows) #8

Closed rasjani closed 5 years ago

rasjani commented 5 years ago

When trying to run webdrivermanager inside cygwin, platform is reported as "CYGWIN_NT*" and binary name lookup fails:

$ webdrivermanager chrome
Downloading WebDriver for browser: 'chrome'
Traceback (most recent call last):
  File "/usr/bin/webdrivermanager", line 10, in <module>
    sys.exit(main())
  File "/usr/lib/python2.7/site-packages/webdrivermanager/cli.py", line 40, in main
    downloader = downloaders[browser](args.downloadpath, args.linkpath, args.os_name)
  File "/usr/lib/python2.7/site-packages/webdrivermanager/webdrivermanager.py", line 47, in __init__
    self.os_name = os_name or self.get_os_name()
  File "/usr/lib/python2.7/site-packages/webdrivermanager/webdrivermanager.py", line 80, in get_os_name
    return namelist[self.platform]
KeyError: 'CYGWIN_NT-10.0'
rasjani commented 5 years ago

Eg, combine "self.os_name" and "self.platform" in webdrivermanager base class into a single value that harmonizes all variations into single platform identification ..

rasjani commented 5 years ago

fixed in 0.7.1