search

Marketcircle / jiraSOAP

Ruby interface to the JIRA SOAP API
http://rdoc.info/github/Marketcircle/jiraSOAP/master/frames
MIT License
31 stars 13 forks source link

Use Attachment objects for uploading issues (Attachment lovin, take 2) #9

Closed rjharmon closed 13 years ago

rjharmon commented 13 years ago

This provides a more rubyish interface for file uploads.

The prior add_base64_encoded_attachments_to_issue_with_key method is retained but deprecated

rjharmon commented 13 years ago

I kept the old method name add_base64_encoded_attachments_to_issue_with_key (with its working implementation) but added a deprecation message.

Any cause you can see for providing any back-compatibility for the AttachmentMetadata class name? Seems to me clients of this library never needed to refer to that old class name, so I didn't do anything about it.

ferrous26 commented 13 years ago

Looks good. Method deprecation is good. I think it is safe to change the class name, but it is also trivial to make it backwards compatible; so could you just create a constant alias?

Other than that i will merge when I get later. Thanks for working on this patch.

rjharmon commented 13 years ago

Hold the phone, that attribute reader deprecation breaks it.

ferrous26 commented 13 years ago

Darn, I missed that as well. I guess it is time to make the test suite public...this pull request is going to have to wait a day or two until I finish auditing the test suite.

ferrous26 commented 13 years ago

Ok, I got enough the test suite audited and merged to have something usable. I'll merge this in tonight (hopefully) and make a release soon.

ferrous26 commented 13 years ago

Applied. Thanks again for the patches!