search

MarketingPipeline / CSS-Image-Loader

Add a image loader & image load error (without adding an HTML element or using JS).
MIT License
21 stars 6 forks source link

improve CSS formatting #7

Closed adrelanos closed 1 year ago

adrelanos commented 1 year ago

Used a CSS formatter for better readability.

The diff looks complex on github but easier after/if https://github.com/MarketingPipeline/CSS-Image-Loader/pull/6 gets merged.

The diff looks much easier to review in a better diff viewer. I used kdiff3. There are minimal changes (double instead of single quotes) except for the code indentation style.

MarketingPip commented 1 year ago

Hey @adrelanos!

Sorry for late response! Hope you had / are having an awesome weekend! :)

More than happy to take this PR in - tho just wanting to clarify. The other pull request you submit, I should close and merge this one only..?

Let me know!

ps; thank you for your improvements on this repo as well in advanced! 👍

adrelanos commented 1 year ago

Thank you for the warm welcome and thank you for your consideration!

I guess pressing the merge (and close) button for both would be safe and not cause any trouble.

MarketingPip commented 1 year ago

You're more than welcome! 😊

On that note tho! Well - I'm correct in saying this branch / PR - has the exact same commits right? Just want to make sure I'm not missing anything & prefer keeping commits / un-needed commits out of repo.

So assuming this repo has same file as the other PR! Let me know and I'll merge this one.

Tho, if the first PR you sent - has something different that this PR does NOT include.

Can I ask you to simply close BOTH the pull request into one?

Hope this isn't asking to much etc. (Trying to keep the commit history pretty!)

Let me know @adrelanos! ps; hope you had an awesome weekend as well!👌

adrelanos commented 1 year ago

You're more than welcome! blush

On that note tho! Well - I'm correct in saying this branch / PR - has the exact same commits right? Just want to make sure I'm not missing anything & prefer keeping commits / un-needed commits out of repo.

Yes, it's the same.

So assuming this repo has same file as the other PR! Let me know and I'll merge this one.

Yes.

Tho, if the first PR you sent - has something different that this PR does NOT include.

No. Nothing different.

Can I ask you to simply close BOTH the pull request into one?

Then this PR.

Hope this isn't asking to much etc. (Trying to keep the commit history pretty!)

I guess how it's split now makes sense because deleting the white spaces is nice to make the later formatting diff easier to read.

MarketingPip commented 1 year ago

Thanks for clearing things up @adrelanos!

Your pull request has been merged finally! Thanks again for the improvements on this repo & hope you enjoy your weekend 👍