Markk116 / LightSailSim

Repository for the master thesis project of Mark Kalsbeek: A Particle System Approach To Designing A Stable Lab-Scale Lightsail
http:\\kalsbeek.dev
MIT License
1 stars 0 forks source link

pip install gives errors #1

Open jellepoland opened 2 months ago

jellepoland commented 2 months ago

Here is the terminal output

`(venv) [..@fedora LightSailSim]$ pip install -e . Obtaining file:///home/jellepoland/surfdrive/phd/code/raw_repositories/LightSailSim Installing build dependencies ... done Checking if build backend supports build_editable ... done Getting requirements to build editable ... error error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully. │ exit code: 1 ╰─> [2 lines of output] running egg_info error: Invalid distribution name or version syntax: init-0.0.0 [end of output]

note: This error originates from a subprocess, and is likely not a problem with pip. error: subprocess-exited-with-error

× Getting requirements to build editable did not run successfully. │ exit code: 1 ╰─> See above for output.

note: This error originates from a subprocess, and is likely not a problem with pip.

[notice] A new release of pip available: 22.2.2 -> 24.0 [notice] To update, run: pip install --upgrade pip (venv) [..@fedora LightSailSim]$ `

jellepoland commented 2 months ago

The problems resolve if you change your pyproject.toml to:

[build-system] requires = ["setuptools >= 61.0"] build-backend = "setuptools.build_meta"

[project] name = "LightSailSim" version = "0.1.0" dependencies = [ "numpy", "pandas", "matplotlib", "scipy", ]

requires-python = ">=3.8" authors = [ {name = "Mark Kalfsbeek"}, ] maintainers = [ {name = "Mark Kalfsbeek"} ] description = "LightSailSim" readme = "README.md" keywords = ["keyword1", "keyword2"] # Add your desired keywords here classifiers = [ "Development Status :: 3 - Alpha", "Programming Language :: Python", "Intended Audience :: Kite Designers, Developers", ]

[project.urls] Repository = "https://github.com/Markk116/LightSailSim/tree/main"

However the code still does not run, problems with relative imports

Markk116 commented 2 months ago

Hey Jelle!

Thanks for raising the issue and providing a fix! I think the reason it still doesn't work is because I was still using relative imports for the interpolator files...oops. This should be fixed in the latest commit. Would you mind checking if it works?

Greets, Mark

jellepoland commented 2 months ago
(venv) [...@fedora LightSailSim]$ python Simulations/Gao_et_al.py
Traceback (most recent call last):
  File "/home/jellepoland/surfdrive/phd/code/raw_repositories/LightSailSim/Simulations/Gao_et_al.py", line 11, in <module>
    from src.particleSystem.ParticleSystem import ParticleSystem
ModuleNotFoundError: No module named 'src'
(venv) [...@fedora LightSailSim]$ 
Markk116 commented 2 months ago

Managed to reproduce the issue via wsl. Issue seemed to disappear after I renamed 'Setup.py' to 'setup.py' and reinstalled the package. Please let me know if this resolved the issue for you too.