search

Markkop / corvo-astral

A Discord Bot that serves as an Wakfu helper
https://github.com/Markkop/corvo-astral
28 stars 4 forks source link

Fix some French translations #12

Closed Vertylo closed 4 years ago

codecov-commenter commented 4 years ago

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #12   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          540       540           
  Branches       103       103           
=========================================
  Hits           540       540
Impacted Files Coverage Δ
src/stringsLang.js 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c98a6d8...bbd538c. Read the comment docs.

Markkop commented 4 years ago

@Vertylo Hey, thanks for contributing! Your Pull Request needs some lint fixing and a merge to solve conflicts with two Spanish translations. I've tried doing this myself, but didn't manage to put the work here in this branch. I've opened this PR https://github.com/Vertylo/corvo-astral/pull/1 to your forked repo by mistake, but maybe accepting it will update this Pull Request with my fixes. Perhaps the ideal would be you doing the fixes. It's pretty easy, run npm run lint -- --fix to lint it Then pull the last changes to master (git pull origin master) and fix the conflict to the following:

 job: {
    en: 'profession',
    es: 'profesión',
    fr: 'métier',
    pt: 'profissão'
  },
  recipesFound: {
    en: 'recipes found',
    es: 'recetas encontradas',
    fr: 'recettes trouvées',
    pt: 'receitas encontradas'
  }

Feel free to contact me if you need help

Markkop commented 4 years ago

Actually I'm sending your Pull Request to another branch so I can mix my changes there as well. Let me know if this will count towards your Hacktoberfest count! Thanks!