Markus-Go / ip-countryside

Creates an accurate ip-to-country database out of the RIR information.
Apache License 2.0
50 stars 15 forks source link

Program terminated!?!? #8

Open RobThree opened 6 years ago

RobThree commented 6 years ago

Running ./creatDb for the first time I encountered a Program Terminated! message. I thought something was wrong. I had to go have a look at the source code only to find out that that's the message it outputs when it's done. Maybe change the message to Completed or Done or something?

Also: maybe a few lines of output during operation when a verbose flag (-v for example) is passed ("Doing X...", "Doing Y...") would be nice; that way you know something is still going on. Some output could be done in delegParser ("Parsing afrinic...", "Parsing lacnic..."), then something like "Sorting list...", then "Checking for and fixing overlaps...", .... and finally "Building ip2country.db".

eg:

$ ./createDb
Parsing afrinic
Parsing lacnic
Parsing arin
Parsing apnic
Parsing ripencc
Reading and sorting data
Checking for and fixing overlaps
Reading and sorting final version
Done!