MarkusAmshove / Kluent

Fluent Assertion-Library for Kotlin
https://markusamshove.github.io/Kluent/
MIT License
867 stars 64 forks source link

Added shouldBeEquivalentTo and shouldNotBeEquivalentTo functionality #184

Closed drcolombo closed 3 years ago

drcolombo commented 3 years ago

Description Added shouldBeEquivalentTo and shouldNotBeEquivalentTo functionality instructing Kluent how to compare objects. By default it will do comparison by each and every non-private property instead of using equals() method.

Checklist

drcolombo commented 3 years ago

Looks like only the project admin may run SonarCube analysis.

MarkusAmshove commented 3 years ago

Oh I didn't know that, I'll look if I can change the permissions.

I'll also review the changes later this week or at the weekend. After our email conversation and my first look into the diff here I think I'm in favor of not touching the assertions that we already have and implement the new ones you already built 👍

MarkusAmshove commented 3 years ago

I had a look at the changes and assertions and I'm ready to merge :+1:

Would you be willing to add a small documentation about the assertion (especially its options) in the docs/ folder? I think that would help the discovery of this cool assertion :-)

drcolombo commented 3 years ago

Sure - will do it tomorrow.

sonarcloud[bot] commented 3 years ago

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 2 Code Smells

82.3% 82.3% Coverage
0.0% 0.0% Duplication

warning The version of Java (1.8.0_272) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11. Read more here

drcolombo commented 3 years ago

Let me know if you have any concerns about the created documentation.

MarkusAmshove commented 3 years ago

Thank you very much again :-) This is now released under v1.64 :-)