Closed drcolombo closed 3 years ago
Looks like only the project admin may run SonarCube analysis.
Oh I didn't know that, I'll look if I can change the permissions.
I'll also review the changes later this week or at the weekend. After our email conversation and my first look into the diff here I think I'm in favor of not touching the assertions that we already have and implement the new ones you already built 👍
I had a look at the changes and assertions and I'm ready to merge :+1:
Would you be willing to add a small documentation about the assertion (especially its options) in the docs/ folder? I think that would help the discovery of this cool assertion :-)
Sure - will do it tomorrow.
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
2 Code Smells
82.3% Coverage
0.0% Duplication
The version of Java (1.8.0_272) you have used to run this analysis is deprecated and we will stop accepting it accepting it soon.Please update to at least Java 11. Read more here
Let me know if you have any concerns about the created documentation.
Thank you very much again :-) This is now released under v1.64 :-)
Description Added shouldBeEquivalentTo and shouldNotBeEquivalentTo functionality instructing Kluent how to compare objects. By default it will do comparison by each and every non-private property instead of using equals() method.
Checklist
AUTHORS
file, if it wasn't already present.