MarkusAmshove / natls

Language Server implementation for the Natural 4GL programming language
MIT License
13 stars 3 forks source link

Implement experimental async initialization #409

Closed MarkusAmshove closed 1 year ago

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

85.0% 85.0% Coverage
0.0% 0.0% Duplication

Claes65 commented 1 year ago

@MarkusAmshove .peek(f -> monitor.progress("Parsing data areas %s".formatted(f.getReferableName()))) -> .peek(f -> monitor.progress("Parsing data areas %s".formatted(f.getReferableName()),0)) in NaturalLanguageService.java line 439. Otherwise it's not responding.

MarkusAmshove commented 1 year ago

@Claes65 when not passing a percentage it increases it automatically: https://github.com/MarkusAmshove/natls/pull/409/files#diff-b9da325b6c2b2cd99f4d5fdc3e89b8a65b46d0cd8309d21a23c204b5b30d3c5aR21

it might not pass the threshold for the message based percentage on that step though, but I don't see that as a problem. Unless I'm missing something :)

Claes65 commented 1 year ago

@Claes65 when not passing a percentage it increases it automatically: https://github.com/MarkusAmshove/natls/pull/409/files#diff-b9da325b6c2b2cd99f4d5fdc3e89b8a65b46d0cd8309d21a23c204b5b30d3c5aR21

it might not pass the threshold for the message based percentage on that step though, but I don't see that as a problem. Unless I'm missing something :)

Not sure - but it hung up Eclipse when 0 was not mentioned. I guess too many messages is sent without the 0 (as 0 means nothing is sent it seems).

MarkusAmshove commented 1 year ago

I'll change it to either not exceeding 100% or not increasing it at all for message based stuff

MarkusAmshove commented 1 year ago

@Claes65 should be resolved in current main branch :)