MarkusAmshove / natls

Language Server implementation for the Natural 4GL programming language
MIT License
12 stars 3 forks source link

Show inline hints for line numbers in input statements #426

Closed MarkusAmshove closed 9 months ago

MarkusAmshove commented 9 months ago

The current implementation renders it like this:

INPUT
    'Field: ' #FIELD line 1/
    'Field2: ' #FIELD2 line 2/
    'Field3: ' #FIELD3

It would be nicer to have them at the start like this:

INPUT
    line 1 'Field: ' #FIELD /
    line 2 'Field2: ' #FIELD2 line /
    line 3 'Field3: ' #FIELD3

For that to work in an easy way, new lines should be part of the IInputStatement.operands()

MarkusAmshove commented 9 months ago

The current implementation renders it like this:

INPUT
    'Field: ' #FIELD line 1/
    'Field2: ' #FIELD2 line 2/
    'Field3: ' #FIELD3

It would be nicer to have them at the start like this:

INPUT
    line 1 'Field: ' #FIELD /
    line 2 'Field2: ' #FIELD2 line /
    line 3 'Field3: ' #FIELD3

For that to work in an easy way, new lines should be part of the IInputStatement.operands()

✅ done

sonarcloud[bot] commented 9 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

97.5% 97.5% Coverage
0.0% 0.0% Duplication