Selenium3 to this library or new one

MarkusBernhardt / robotframework-selenium2library-java

Java port of the Selenium 2 (WebDriver) Python library for Robot Framework

Apache License 2.0

46 stars 51 forks source link

Selenium3 to this library or new one #86

Open Hi-Fi opened 7 years ago

Hi-Fi commented 7 years ago

While Selenium3 has couple of release versions already, how should it handled within this library? Should this stick at Selenium2 (as name states), or go to Selenium3 (without changing the name, or with new name and version)?

MarkusBernhardt commented 7 years ago

Hi Juho,

to be honest, I believe this library should be let to die. AFAIK the python version is nowadays fully compatible to Java/Jython that there is simply no reason to maintain this.

What is your opinion on this?

Cheers, Markus

Hi-Fi commented 7 years ago

Currently in most of the places I have used this library I don't see possibility to move to Python version. Main reason for that is the dependency management with Maven and Gradle. Usually there even has been internal Artifactory or Nexus which is mirrering Maven central and allowing to run tests without internet connection. For Python version I don't see that kind of possibility, and it would require e.g. Python installations to all CI agents that test needs to be run on.

Maybe best option would be (if trusting that Jython is staying up to date long enough) to have Selenium2library (original one) also delivered through Maven central as RF is done. Before that happens, I think this version is needed. Or some Selenium2Library for RF, which can be used just as a dependency from Maven central.

Hi-Fi commented 7 years ago

Related to this it seems that there has been discussion to name Python version of Selenium2Library to SeleniumLibrary. Same thing might be good to this library, too, if the development is continued here.

Hi-Fi commented 7 years ago

@MarkusBernhardt: Any ideas? Selenium3 is needed for Geckodriver, so that update is needed at least to keep library usable.

Hi-Fi commented 7 years ago

Ideas collected:

Name changed to SeleniumLibrary
Version numbering from Selenium version (e.g. 2.9.2.0 for Selenium 2.9.2 (reserving last number to library fixes)
Release versions for Selemium 2 (2.9.2) and Selenium 3 (3.4.0) with mentioned numbering
Testing can utilize e.g. https://github.com/Ardesco/selenium-standalone-server-plugin to download browser and simplify the development.

Just made a quick try, and Selenium 3 needed only 1 code change and geckodriver.