search

MarkusBernhardt / robotframework-selenium2library-java

Java port of the Selenium 2 (WebDriver) Python library for Robot Framework
Apache License 2.0
46 stars 48 forks source link

Opening a remote browser with custom web driver timeouts #87

Open ghost opened 7 years ago

ghost commented 7 years ago

The default way of creating a web driver has a hard-coded timeout for 3 hours on socket timeout. We are using browser spinned up in docker containers, and no matter if we wait on port to be opened, sometimes it is too early to connect. That ends up in waiting for 3 hours.

This modification adds an overload with two extra arguments for Open Browser keyword, and you can specify both connection and socket timeouts. It has effect only for remote browsers of course.

The implementation mimics the original behaviour of default driver creation, and the code plays with internal classes of selenium is isolated.

A TimeUtils with JUnit tests also added for convention, so the Open Browser keyword understands Robot Time String format and converts them to milliseconds for the API.

Kudos to @JoepWeijers for the patch idea.

ghost commented 7 years ago

@MarkusBernhardt do you have any plans on this?

ghost commented 7 years ago

Ehm, poke.