MarkusBordihn / BOs-Adaptive-Performance-Tweaks

Adaptive Performance Tweaks is a collection of Minecraft Forge server-side Mod which automatically adjust specific settings on the server to allow a more balanced TPS/FPS.
Other
4 stars 2 forks source link

Create Incompability #29

Closed MarkusBordihn closed 1 year ago

MarkusBordihn commented 1 year ago

Create is using Living Entities for some of their interactive blocks with MobCategory.MISC like: https://github.com/Creators-of-Create/Create/blob/131c9a5479ff29dd4135d64cd182de5cb12acaef/src/main/java/com/simibubi/create/AllEntityTypes.java#L35-L69

This leads to the issue that the respawn of the same entity, which happen on a regular basis, will be blocked like:

[03Dec2022 23:34:34.098] [Server thread/DEBUG] [APTweaks(Spawn)/]: [Allow join (low load)] For ControlledContraptionEntity['Stationary Contraption'/49831, l='ServerLevel[Create Test]', x=68.00, y=69.00, z=-333.00] in minecraft:overworld and 0 in world
[03Dec2022 23:34:34.098] [Server thread/DEBUG] [APTweaks(Core)/]: [Joined] Entity create:stationary_contraption (ControlledContraptionEntity['Stationary Contraption'/49831, l='ServerLevel[Create Test]', x=68.00, y=69.00, z=-333.00]) joined minecraft:overworld.
[03Dec2022 23:34:35.594] [Server thread/DEBUG] [APTweaks(Spawn)/]: [Spawn Limiter 10] Blocked join event for SuperGlueEntity['Super Glue'/49874, l='ServerLevel[Create Test]', x=66.00, y=69.00, z=-333.00] in minecraft:overworld.

Normally mods should avoid pseudo mobs for interactive blocks, but in this case we know that create has no real mobs so we could just exclude create from the entity based optimizations.