search

MarkusBordihn / BOs-Adaptive-Performance-Tweaks

Adaptive Performance Tweaks is a collection of Minecraft Forge server-side Mod which automatically adjust specific settings on the server to allow a more balanced TPS/FPS.
Other
4 stars 2 forks source link

Passive Mobs Classified Incorrectly #30

Closed MPRATCH-V2 closed 1 year ago

MPRATCH-V2 commented 1 year ago

Description: Essentially every passive mob is labeled in the config as a neutral mob. Maybe there is some reason for this but it was causing me issues since I have a mod that makes bees smaller and increases the amount of them. Passive mobs are mobs that will not attack you whether or not you attack them. Neutral mobs are passive until an event is met, whether the event is attacking them, getting too close, or anything else. Hostile mobs will attempt to attack you as soon as they notice you. Having an abundance of bees made it so that no passive mobs such as cows, pigs, or chickens would spawn.

Reproduction: Steps to reproduce the behavior:

  1. Have an abundance of a neutral mob such as bees.
  2. Try to find cows.
  3. Cry.

Expected behavior: No passive mobs spawn in.

Debugging: I closed my game before submitting this and won't be reopening it to check the debug. If I remember I will check it next time I boot up my mod pack.

Full Modlist: I'm trying to stick to the template as best I can so although I don't see how it's relevant as the mobs are mislabeled in the config, my mod list will be at the bottom of this report.

Additional Info: I put the bee mod that I referenced at the top of the list. As far as I'm aware it is the only mod that would be conflicting with the spawning of passive mobs. That being said as previously stated in the config the mobs are mislabeled which if corrected should fix the issue. I'm tired and was about to go to bed when I found the issue and didn't feel like fixing the config so I wound up just disabling the adaptive spawns mod. If I remember next time I boot up my game I will re-enable it and alter the config to see if it fixes the issue.

This is the bee mod that I referenced

Realistic Bees (Forge)
Serilum
realisticbees_1.19.2-2.8.jar

Chunk Animator Lumien231 ChunkAnimator-1.19.2-1.3.6.jar

Just Enough Items (JEI) mezz jei-1.19.2-forge-11.4.0.286.jar

Adaptive Performance Tweaks (Bundle) Kaworru adaptive_performance_tweaks_1.19.2-6.3.0.jar

Adaptive Performance Tweaks: Core Kaworru adaptive_performance_tweaks_core_1.19.2-6.3.0.jar

Adaptive Performance Tweaks: Gamerules Kaworru adaptive_performance_tweaks_gamerules_1.19.2-6.3.0.jar

Adaptive Performance Tweaks: Items Kaworru adaptive_performance_tweaks_items_1.19.2-6.3.0.jar

Adaptive Performance Tweaks: Mods Kaworru adaptive_performance_tweaks_mods_1.19.2-6.3.0.jar

Adaptive Performance Tweaks: Player Protection / Child Mode Kaworru adaptive_performance_tweaks_player_1.19.2-6.3.0.jar

Adaptive Performance Tweaks: Spawn Kaworru adaptive_performance_tweaks_spawn_1.19.2-6.3.0.jar

Additional Structures XxRexRaptorxX Rex's-AdditionalStructures-1.19.x-(v.4.0.2).jar

Advancement Frames MehVahdJukaar advancementframes-1.19.2-2.0.0.jar

AI Improvements QueenOfMissiles AI-Improvements-1.19.2-0.5.2.jar

Apotheosis Shadows_of_Fire Apotheosis-1.19.2-6.0.1.jar

AppleSkin squeek502 appleskin-forge-mc1.19-2.4.2.jar

AttributeFix DarkhaxDev AttributeFix-Forge-1.19.2-17.1.2.jar

Auto Planting Forests Lothrazar autoplant-1.19-1.0.1.jar

Balm (Forge Edition) BlayTheNinth balm-4.5.3.jar

Better Beacon Placement (Forge) Serilum betterbeaconplacement_1.19.2-2.1.jar

Better Conduit Placement (Forge) Serilum betterconduitplacement_1.19.2-2.0.jar

Better Villages - Forge jtl_elisa bettervillage-forge-1.19.2-2.0.0.jar

Bookshelf DarkhaxDev Bookshelf-Forge-1.19.2-16.1.11.jar

Botany Pots DarkhaxDev BotanyPots-Forge-1.19.2-9.0.13.jar

Botany Pots Tiers Ultramegaaa BotanyPotsTiers-Forge-1.19.2-3.1.0.jar

Botany Trees DarkhaxDev BotanyTrees-Forge-1.19.2-5.0.1.jar

BuildPaste mistrx_ BuildPasteMod-1.19.2v1.9.5.jar

Caelus API (Forge) TheIllusiveC4 caelus-forge-1.19.2-3.0.0.6.jar

Chunk-Pregenerator Speiger Chunk Pregenerator-1.19-4.1.1.jar

Cloth Config API (Fabric/Forge) shedaniel cloth-config-8.2.88-forge.jar

Clumps Jaredlll08 Clumps-forge-1.19.2-9.0.0+11.jar

Collective (Forge) Serilum collective-1.19.2-5.16.jar

Colytra (Forge) TheIllusiveC4 colytra-forge-6.0.0+1.19.2.jar

Configured MrCrayfish configured-2.0.1-1.19.2.jar

Connected Glass SuperMartijn642 connectedglass-1.1.4b-forge-mc1.19.jar

Cull Leaves Motschen cullleaves-forge-3.0.1.jar

Curios API (Forge) TheIllusiveC4 curios-forge-1.19.2-5.1.1.0.jar

Diagonal Fences Fuzs_ DiagonalFences-v4.2.3-1.19.2-Forge.jar

Display Case ChappiePie Display Case-forge-1.19-1.0.3.jar

Dragon Drops Elytra (Forge) Serilum dragondropselytra_1.19.2-1.7.jar

Dragonite Kreepz_TTV 1.19.2-dragonite-1.1.jar

Dynamic Asset Generator lukebemish dynamic_asset_generator-forge-1.19.2-1.2.0.jar

Easy Mob Farm Kaworru easy_mob_farm_1.19.2-4.3.0.jar

Effortless Building Requioss effortlessbuilding-1.19-2.37.jar

Elytra Physics ImJ0shh_ ElytraPhysicsForge-1.1.1.jar

Enchantment Descriptions DarkhaxDev EnchantmentDescriptions-Forge-1.19.2-13.0.3.jar

End Remastered jack_bagel endrem_forge-5.2.1-R-1.19.X.jar

Entity Culling Fabric/Forge tr9zw entityculling-forge-1.5.2-mc1.19.1.jar

Excavated Variants lukebemish excavated_variants-forge-1.19.2-1.0.3.jar

Fast Leaf Decay olafskiii FastLeafDecay-30.jar

FastFurnace Shadows_of_Fire FastFurnace-1.19.2-7.0.0.jar

Fastload FluffyBumblebe3 Fastload-Reforged-2.4.0+1.19.2.jar

FastSuite Shadows_of_Fire FastSuite-1.19.2-4.0.0.jar

FastWorkbench Shadows_of_Fire FastWorkbench-1.19.2-7.0.1.jar

Flat Bedrock (Forge / Fabric) Sunekaer flatbedrock-forge-2.0.0-build.14+mc1.19.2.jar

ForgeEndertech EnderLanky ForgeEndertech-1.19.2-10.0.5.0-build.0599.jar

Forgiving Void BlayTheNinth forgivingvoid-forge-1.19-7.0.0.jar

Get It Together, Drops! bl4ckscor3 getittogetherdrops-forge-1.19.2-1.3.jar

Hammer Lib Zeitheron HammerLib-1.19.2-19.2.39.jar

Hardmode Mining - Rarer Ores Zetal HardModeOres-1.19-1.7.jar

I Know What I'm Doing (IKWID) HeckinChloe IKnowWhatImDoing-5.1.1-forge.jar

InsaneLib Insane96MCP InsaneLib-1.7.2-mc1.19.2.jar

Inventory Sorter cpw inventorysorter-1.19.2-21.0.4.jar

Inventory Totem (Forge) Serilum inventorytotem_1.19.2-1.8.jar

Iron Chests ProgWML6 ironchest-1.19.2-14.2.7.jar

Iron Furnaces [FORGE] XenoMustache ironfurnaces-1.19.2-3.6.3.jar

JourneyMap techbrew journeymap-1.19.2-5.9.0beta3-forge.jar

Just Enough Resources (JER) way2muchnoise JustEnoughResources-1.19.2-1.2.0.188.jar

Large Ore Deposits EnderLanky AdLods-1.19.2-7.0.4.0-build.0599.jar

Lazy DataFixerUpper(LazyDFU) [FORGE] Corgi_Taco lazydfu-1.0-1.19+.jar

Library Ferret - Forge jtl_elisa libraryferret-forge-1.19.2-3.0.0.jar

Material Elements Kaworru material_elements_1.19.2-6.0.0.jar

Memory Settings[Forge/Fabric] someaddon memorysettings-1.19.2-2.2.jar

Memory Usage Screen [Forge/Fabric] morimori0317 memoryusagescreen-forge-mc1.19-1.6.jar

Mob Grinding Utils vadis365 mob_grinding_utils-1.19.2-0.4.46.jar

Moonlight Lib MehVahdJukaar moonlight-1.19.2-2.1.10-forge.jar

More Decorative Blocks - BlackWolf Design [FORGE & FABRIC] 00theblackwolf00 MoreDecorativeBlocks-1.19.2-1.0.0-[FORGE].jar

More Dragon Eggs Darkere moredragoneggs-3.2.jar

More Village Trade Options - Balance Version theskycloud More Villager Trade Items - Balance Version V1.4.2.jar

More Villagers SameDifferent morevillagers-forge-1.19-4.0.3.jar

Mouse Tweaks YaLTeR MouseTweaks-forge-mc1.19-2.23.jar

One Twenty 1.20 Backport kleiders3010 One Twenty Backport 1.19.2 V1.2.0.jar

OreBlockSmelting Thompete oreblocksmelting-1.0.0-1.19.2.jar

Patchouli Vazkii Patchouli-1.19.2-77.jar

Physics Mod haubna physics-mod-2.9.2-mc-1.19.x-forge.jar

Placebo Shadows_of_Fire Placebo-1.19.2-7.0.1.jar

Puzzles Lib Fuzs_ PuzzlesLib-v4.3.12-1.19.2-Forge.jar

Randomium Ore MehVahdJukaar randomium-1.19.2-1.19.jar

Realistic Name Tags lu3arm realisticnametag-0.2.jar

Repurposed Structures (Forge) telepathicgrunt repurposed_structures_forge-6.3.8+1.19.2.jar

Respawning Shulkers (Forge) Serilum respawningshulkers_1.19.2-1.9.jar

Server Performance - Smooth Chunk Save[Forge/Fabric] someaddon smoothchunk-1.19.1-2.0.jar

Shields+ Insane96MCP Shields+-1.3.2-mc1.19.2.jar

Simple Quarry Zeitheron SimpleQuarry-1.19.2-19.2.1.jar

Skin Layers 3D (Fabric/Forge) tr9zw 3dskinlayers-forge-1.5.2-mc1.19.1.jar

Snow Under Trees bl4ckscor3 snowundertrees-1.19.2-1.3.jar

Sophisticated Backpacks P3pp3rF1y sophisticatedbackpacks-1.19.2-3.18.33.742.jar

Sophisticated Core P3pp3rF1y sophisticatedcore-1.19.2-0.5.26.166.jar

The One Probe McJty theoneprobe-1.19-6.2.2.jar

Tiered Shulker Boxes lukegrahamlandry tieredshulkerses-1.19.2-1.1.43.jar

Tool Leveling+ [Forge] Buecher_wurm toolleveling-forge-1.19.2-1.4.1.jar

Warden Enhancer FiveNights2161 WardenEnhancer.jar

Waystones BlayTheNinth waystones-forge-1.19-11.1.0.jar

XP Tome bl4ckscor3 xptome-1.19-2.1.7.jar

YUNG's API (Forge) YUNGNICKYOUNG YungsApi-1.19.2-Forge-3.8.2.jar

YUNG's Better Desert Temples (Forge) YUNGNICKYOUNG YungsBetterDesertTemples-1.19.2-Forge-2.2.1.jar

YUNG's Better Dungeons (Forge) YUNGNICKYOUNG YungsBetterDungeons-1.19.2-Forge-3.2.2.jar

YUNG's Better Mineshafts (Forge) YUNGNICKYOUNG YungsBetterMineshafts-1.19.2-Forge-3.2.0.jar

YUNG's Better Ocean Monuments (Forge) YUNGNICKYOUNG YungsBetterOceanMonuments-1.19.2-Forge-2.1.0.jar

YUNG's Better Strongholds (Forge) YUNGNICKYOUNG YungsBetterStrongholds-1.19.2-Forge-3.2.0.jar

YUNG's Better Witch Huts (Forge) YUNGNICKYOUNG YungsBetterWitchHuts-1.19.2-Forge-2.1.0.jar

YUNG's Bridges (Forge) YUNGNICKYOUNG YungsBridges-1.19.2-Forge-3.1.0.jar

YUNG's Extras (Forge) YUNGNICKYOUNG YungsExtras-1.19.2-Forge-3.1.0.jar

MarkusBordihn commented 1 year ago

Thanks a lot for the detailed report. The classification of the mobs (passive, neutral, aggressive) are independent from the entity type. This means if you have a huge amount of bees (neutral), it should not affect the spawn of cows (wrongly classified as neutral) at all, because these are two different entity types.

I will try to reproduce the issue with Realistic Bees. In the last update I implemented a patch so allow more spawning of bees if they are near a hive, maybe this is related to this.

In general the "debug" function should give a clear reason why a specific entity type is blocked from spawning.

MarkusBordihn commented 1 year ago

I tried to reproduce the issue with "no cows", but was not really able to reproduce the issue on my side. :( I was able to find cows even if I populated the world with 200 different kinds of bees, not in the same chunks or very near the spawned bees but this is expected.

I assume that your issue is more related to the Minecraft spawn cycle itself, which limits the mob spawning per mob category as well. See: https://minecraft.fandom.com/wiki/Spawn#Spawn_cycle

If you are able to provide a debug log which shows that this mod blocks any spawn which shouldn't be blocked I'm happy to take an additional look into this. If you find no corresponding entries for "cow" in the debug log, it means that Minecraft itself decided it's to crowed for any additional natural spawns from the same mob category.

Anyways I prepared a fix for the wrong categorization for passive, neutral mobs but as I mention it will have not have any effect on the current logic, which is based on entity types.

MPRATCH-V2 commented 1 year ago

Thank you for attempting to fix this issue promptly I really do appreciate it. I enabled the debug logging and flew around for a bit in creative to see if anything spawned. The first time I did this I did manage to spawn two chickens. When testing again I saw only bees or hostile mobs. I looked in the log and saw no mention of chickens, cows, pigs, or any other animal I've had an issue with. Based on these findings I assume your suggestion that it's related to the Minecraft spawn cycle as opposed to the mod is likely correct. If you have no further questions feel free to close this report and thank you once again for looking into this matter.

MarkusBordihn commented 1 year ago

Thanks a lot for the feedback. I totally understand that's it not always easy to isolate such issues, that was one of the main reason why I added debug logging message to all action from this mod.

I'm also aware that the mod is not able to cover 100% of all use-cases (different kind of mods). For this reason I'm always thankful to receive user issue report to optimize specific parts which are maybe less relevant for my personal use-case.

In this specific case limiting the numbers of bees would be an option, but I know that a lot of people love to have a lot of bees and hives around them. But if this is an option for you, I'm happy to add a configuration file for "realisticbees" so that they could be limited to avoid such side effects with the Minecraft spawn cycle.