1.16.5/1.18.2/1.19.2/1.19.4 - Mod Idea ``Adaptive Chunk Generation Protection`` or at least 1.19.2/1.19.4 +

P3rf3ctXZer0 commented 1 year ago

The Scenario

When a chunk is loading it causes server lag because even before it loads entity's structures and more are loading. In larger servers this really bad especially if flight is enabled or custom biomes that utilize terrablender( See my research https://github.com/P3rf3ctXZer0/P3rf3ctXZer0s-Workshop/issues/3 ) though even as I dig deeper I suspect this is part of a much bigger issue related to chunk generation since adubbz is not a bad coder I am not entirely sure he is at fault ... At any rate - when flight is enabled and lets say chunks are not loaded the player can fly off to the void and sometimes the server catches up and sometimes the world generation just stops until a server restart which can demoralize players. (I have had people mistake chunk gen for pack issues. which I mean it does affect player experience.) What this also means is this has the power to kill servers legitimately. (Without hacks or spam.) If you server ever says Moved Too Quick it means the server lost track of the players coordinates or the player is outside of world generation.

The Solution

Create a visible border display similar to other video games that the player can see; that prevent player travel.
Generate Chunks off main thread based on player location and server view distance or in special cases structure generation since mods like YUNGs Nether fortresses exist. (Example would be a server allows 4 view distance the borders would remain up until at least 4 chunks generated or expand if a large structure also needed to generate.)
Prevent all mob generation outside world border especially mod mobs.
Prevent flight at border as a way to prevent flying over generating chunks. (This would eliminate flying into the void.)
You would also need to create a teleport guard so mods like FTB Essentials or other mods with RTP could not cause the world to lag horribly; now that I think about dimension mods too.

Why Chunk Pregen Mods Are Not The Answer

Pregen mods take a ton of time and from what I could tell still don't actually fix things with tps completely because they cannot predict what a player will do. I generated 100000 chunks and players still found a way to bog the server down through generation of new chunks. The other thing as a modpack developer what if I add a new mods and now it has new chunk generation ore or something else now in order to obtain that ore or generation material I would need to pregen again. Its a game of cat and mouse and not really a solution. The other thing is sometimes after server restart chunks unload or in some rare cases cease all together and then need to regen once again. Pre chunk generations is not a valid solution.

Why am I telling you this?

I happen to know like me you want the smoothest minecraft experience especially even if just based on performance. I also know you can code and unfortunately though I have the idea unless I get a brain implant 4,760,000 dollars I cannot. Since I had this epiphany you can take all the credit if you make this mod and rename it how you like or you can just give me a simple Inspired by Zer0Necrosis and I would appreciate it. Anyways I hope to see you bring this solution to life and you let me know so we can finally have a Minecraft experience worth having.

Thank you for listening.

MarkusBordihn commented 1 year ago

Thanks for the sharing this idea. In general it's not so easy to realize, because you need to use Mixin and Core Modding which is something I will not implement with the Adaptive Performance Tweaks.

But there already some mods which tackle this kind of issue, with very less or no side effects like:

Your idea is basically a combination of these three functionality with some additional checks.

But let me see if there is anything I could do in this directly, because I facing the same issue with flying players which generating a lot of chunks during their exploration which lags the game for all others.

P3rf3ctXZer0 commented 1 year ago

I cannot imagine how hard or easy it may be to implement. I am mentally unable to code so no pressure at all. I just observed the way the system was working and saw issues.

MarkusBordihn / BOs-Adaptive-Performance-Tweaks