MarkusBordihn / BOs-Adaptive-Performance-Tweaks

Adaptive Performance Tweaks is a collection of Minecraft Forge server-side Mod which automatically adjust specific settings on the server to allow a more balanced TPS/FPS.
Other
4 stars 2 forks source link

Addition to `Spawn` #45

Open SiverDX opened 1 year ago

SiverDX commented 1 year ago

Mod: https://www.curseforge.com/minecraft/mc-mods/gothic-rpg

      passiveMobsList = builder.comment(Constants.CONFIG_LIST_PASSIVE_MOBS)
          .define("PassiveMobsList", new ArrayList<String>(Arrays.asList(
          // @formatter:off
            "gothic:meatbug",
            "gothic:meatbug_tamed"
          // @formatter:on
          )));
      neutralMobsList = builder.comment(Constants.CONFIG_LIST_NEUTRAL_MOBS)
          .define("NeutralMobsList", new ArrayList<String>(Arrays.asList(
          // @formatter:off
            "gothic:npc_farmer",
            "gothic:npc_oldcamp_hunter"
          // @formatter:on
          )));
      hostileMobsList = builder.comment(Constants.CONFIG_LIST_HOSTILE_MOBS)
          .define("HostileMobsList", new ArrayList<String>(Arrays.asList(
          // @formatter:off
            "gothic:bloodfly",
            "gothic:bloodfly_hornet",
            "gothic:dragon_snapper",
            "gothic:gothic_wolf",
            "gothic:ice_wolf",
            "gothic:lurker",
            "gothic:molerat",
            "gothic:razor",
            "gothic:scavenger",
            "gothic:shadowbeast",
            "gothic:snapper",
            "gothic:stone_guardian",
            "gothic:warg"
          // @formatter:on
          )));
SiverDX commented 1 year ago

Question:

How do the mob types need to be specified? The hostile creatures act like hostile creatures (e. g. attack on sight) but I think they (or some?) are specified as Passive (Ambient)

Would that cause a problem?

SiverDX commented 1 year ago

Would it maybe be possible to allow for dynamic loading by defining the config specs as list and then parsing the directory for valid files and creating the config elements for each found file?

MarkusBordihn commented 1 year ago

The categorization like passive, neutral and aggressive is not checking / verifying the actually mob type. It's more to be able to have three different kinds of groups to define different spawn caos for each of the group.

There is already a "Custom Spawn Config" which allows you to add any kind of mobs which are not already covered by one of the other lists.

SiverDX commented 1 year ago

Yeah I saw the custome one but only allows you to add one configuration (unless you want to throw multiple mods into one), doesn't it?

MarkusBordihn commented 1 year ago

I will check if I could add a easily a dynamic config or something like this. Unfortunately the standard implementation only allows hard-coded config files.