Strength and health increases do not show in attributes

[sprocketaudio]

Describe the bug Unless I am missing something, when you are under the thresholds to receive the strength and health buffs, this does not show when you query your player attributes?

Command to query - /attribute SprocketGames minecraft:generic.attack_damage get

As you can see from the images above, using the vanilla command gives me the same value as the L2 Library mods 'stats' tab in the inventory. This also doesnt show this mod as a modifier, however you can see that I should currently have '1.26' as a modifier?

To Reproduce Steps to reproduce the behavior:

1. Install this mod and L2 Library
2. Make sure you have health and strength when below a certain threshold in the config file
3. load in to the game and check your stats in the mod
4. run the attribute command to see what is reported
5. Check the stats window in the inventory to confirm same value

Expected behavior I would expect to see the strength stat higher when running the command and it shown as a modifier in the stats window

[MarkusBordihn]

Thanks for the feedback. The mod is directly adjusting the dealt and received damage for several reasons and is not adding any additional modifier or so.

The reason for this is mostly for performance reason, because adding additional modifier depending on the level and used weapon would cause to many updates on the server and client side.

For this reason the dealt and received damage (including the weapon damage) is directly calculated and adjusted on the server so that the client doesn't need to perform any additional calculation or so.

I will update the wiki documentation to make sure this is covered as well.

[sprocketaudio]

ah ok thank you - I thought it might be something like this! Does that mean then that its a direct scaling modifier of the current attributes? So for example - if my damage attribute is 2.55 and this mod is currently at 1.5 increase is the damage 2.55 x 1.5?

[MarkusBordihn]

The mod is adding all multipler to the total end damage, so after all weapon class boosts, any effects , armor and possible block damange came into play.

The mod includes different dynamics to make it fair and more challanging. For example your item damage increase with each usage. Howevery after killing a specific amount of mobs, your dealt damage get decreased and the mobs dealing more damage to you, so they get stronger.

The updated version shows a little bit more details to this.

[sprocketaudio]

Thanks for the info - if you haven't already considered it - could you add the damage and damage reduction amounts to the gui hover stat page? Currently I can only see it with the command player_progression stats?