MarkusBordihn / BOs-Easy-NPC-Epic-Fight

Easy NPC: Epic Fight Mod Integration
Other
1 stars 1 forks source link

[Feature Request] Better support for Husk and Zombie and adding Humanoid NPCs. #5

Open MechRW opened 4 months ago

MechRW commented 4 months ago

I created a JSON animation data package using the code provided by the epic fight author , but unfortunately, it just work to skeleton

i dont know why and when can we let npc use weapon animation

MechRW commented 4 months ago

btw,may you can let husk and zombie use ishumanoid:true? or your npc may never used epic fight weapon. may you make a Humanoid npc next update ? skeleton's skin is really ugly to make npc,and your mod is not match with Armourer’s Workshop,i cant find a way to make skeleton cool anymore.
i was try to chance your jar , this crush()

when skeleton with WeaponsOfMiracles be killed ,the game will Suddenly it turned into a small black box on a white screen, and then the game couldn't be operated.

and,skeleton npc only have idle animation, no attacking animation.

MarkusBordihn commented 2 months ago

Thanks for your feedback. I will overwork some of the models to support the humanoid model as best I can and will add the humanoid NPCs.

If you get any animation errors for e.g. with the WeaponsOfMiracles you should report the issue to the Epic Fight developer instead. This mod integration itself is not adjusting the animations or renderer, which mean any animation bugs are caused by the weapon itself or by the Epic Fight mod.

Similar to the JSON data pack, I'm not owning the data-pack functionality, so any issues with them should be discussed with the Epic Fight developer instead.

However I'm happy to make adjustments on my side if needed.

MechRW commented 2 months ago

I'm sorry that due to the time difference and my personal work schedule, I couldn't get back to you as soon as possible.

The problem actually lies in the fact that the CNPC author has stopped updating higher versions, which has led to the invalidation of all CNPC and Epic Fight adaptations currently produced by the Chinese community.

However, the higher versions of NPCMOD currently only have you as an Easy NPC now, and the epic fight author has been rated as "relatively lazy" in the Chinese community. Most of the action pack adaptation and mod compatibility are even mostly done by the community.

So we can only say that we place our hopes on the authors of NPCMOD(like you now), not on the authors of EF. Of course, we may be able to update animations and weapon effects, but we really can't help him compatibility with NPC MOD anymore. Also, as an aside, can you add a feature like "Soul Gem" that directly refreshes the set NPC (including fashion workshop and equipment data)? Currently, it can only be imported and exported as data, and everything cannot be separated from the NPC wand

MechRW commented 2 months ago

Chinese community players have even achieved the restoration of the combat system in Sekiro Shadow Die Twice using CNPC. https://www.bilibili.com/video/BV1ND421E7S7 But as the higher version CNPC authors abandoned the update, everything became meaningless.

I have seen the Soul Gem function, thank you. We are currently testing whether it is compatible with the Fashion Workshop.

MarkusBordihn commented 2 months ago

Thanks for the feedback and no worries I'm not a full time mod developer and it's more like a hobby for me.

In general I will not be able to add additional functionality for epic fight, because as you already mention their support is limited and they will also do no back ports for older versions regardless of the issue. :(

I tried to contact them for the humanoid model, because they have no humanoid renderer and only a player renderer, but got not really any feedback here.

Which mean I depend on their integration. However I currently working on other features and a fake player NPC which should theoretically allow additional use-cases like your shared video.

Easy NPC goal was never to be a copy of Custom NPCs and the goal was to make a version which is maintainable and easy to use for all players across all ages.

MechRW commented 2 months ago

I understand your efforts, perhaps my statement is more offensive. I didn't say I wanted you to become a shadow of CNPC, it's just that I might consider it from a user's perspective, People will naturally compare your mod with CNPC

In many mods without support for 1.20.1, it is often very awkward. For both players and developers.

Wishing you all the best. The author of epic fight is praised by the Chinese community for everything except laziness. Moreover, most Chinese players are not good at playing and do not like darksoul type operations. They prefer firearm mods (but TAC is also stuck at 1.18),or yes Steve mod So only a few people make adaptations for epic fight