search

MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
20 stars 8 forks source link

[Bug] NPC's pose reset after reload with 3.11.x #110

Closed Shangrii closed 7 months ago

Shangrii commented 7 months ago

So I have a modded 1.18.2 server wich has a bunch of NPC's on the spawn, and whenever I do a server restart, they reset their poses to a default one. I've been testing and apparently only happens with custom and advanced poses, the default ones seems to not be affected, I also discovered that it also happens with NPC rotation as well. Also when I tried to fix the NPC poses, I started to load some backups that I made on a previous version of this mod (3.10.0 or 3.9.0) and NPC poses work just fine but If I try to import an NPC backup that I made on the newest version it doesnt,

Steps to reproduce the behavior:

  1. Change the NPC pose or rotation on newest version
  2. Restart the server

Expected behavior This wasnt happening on previous versions, npc poses and rotation should be the same after a server restart and load when you import an NPC to the world

MarkusBordihn commented 7 months ago

Thanks a lot for the report. This is something I just notice myself and already remove the 3.11.x version from Forge and Fabric. It's happen because currently working on a Fabric Port and need to remove/rewrite all Forge specific features, which means I need to move and rewrite a lot of files.

The good news is that during the work on this I fixed a bunch of issues including this. The Bad news is that it will take a few more days before the new 4.x version is ready, so in the mean time, please downgrade to 3.10.x.

Before upgrading to 4.x you should make sure that you have a backup of your NPCs (exporting presets). I tried my best to make it compatible with former versions but to make sure it works with Fabric and Forge I had to adjust a lot of parts.

Shangrii commented 7 months ago

Hello again, I've downgraded my server to previous version 3.10.0 and the issue still persists, the most recent version in wich this bug is not present is in 3.9.0, the only problem is that version doesnt render the custom armor textures from other mods.

At this point I don't know if it would be better to stay with version 3.9.0 and wait for 4.x.x or downgrade to another version, I only have NPC's with custom dialogs, and trades nothing too complicated

btw, thanks a lot for your dedication

Edit: So apparently what happened is that theres 2 published version of the 3.10.0 mod for minecraft version 1.18.2 and the one that's updated on 03/18/2024 has the same issue as 3.11.0 version, but the one uploaded on 03/11/2024 doesnt

Captura

MarkusBordihn commented 7 months ago

Thanks for the feedback. I removed the "wrongly" 3.10.0 version.

I currently working on fixing some critical bugs for 4.x and will release this version asap as beta version without the Fabric port in the next days.

MarkusBordihn commented 7 months ago

I just released a 4.x beta for 1.18.2 for further testing:

This should fix the issue and some others as well. It could take some time until this version is live.