MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
20 stars 8 forks source link

Update feedback #131

Open DeadmanTheGod opened 7 months ago

DeadmanTheGod commented 7 months ago

I love the mod and have been using it on the server since the update. I want to list issues and things I have noticed.

1) Skins - skins work for some people and not others. I mean, if I were to set a skin, both of us could see it, but the 3rd person may not. Resetting the npc or skin doesn't work. Restarting minecraft doesn't work. They may see a different skin, tho. Example: One member was able to see an Ash from pokemon skin but not a bear skin.

2) Npc pathing - I know there is only so much you can do for pathing, but I will state this observation anyway fairies get stuck on blocks above them. It doesn't matter if it's full blocks or slabs or modded roofs they tend to just lock into place on something above them. Npc love fences. Npcs will frequently climb places just to fall 2+ blocks into a fenced area.

3) Lack of Npc finder - Had an npc sink through the ground and ended up in a cave system somehow. With the help of journeymap and spectator mode, I was able to find and leash the npc n bring it to the correct location.

4) Optimization - I love the optimization of this mod. Even with 30 npcs in a heavy loaded area, it still ran with no stutters or issues. Keep it up.

I will keep using the mod and come up with fun ways to use these npcs. One is being a music store clerk. Thanks for your hard work.

MarkusBordihn commented 7 months ago

Thanks for the feedback.

1.) I notice during testing that the Skin system works not reliable for this reason I rewrite the whole system for better performance and added additional checks to give the users corresponding warning and error messages. I currently checking of adding "world-based" and "server-based" skins, so that users don't need to download anything by them-self.

2.) I will add some additional checks for the pathing to try to avoid this typical scenairos.

3.) Basically there is an command for this like /easy_npc configure which gives you a list of all the NPCs. I currently checking if I could sort the list based on the distance of the player.

The NPC wand will also highlight NPCs in short range, but it's sounds like a good idea to add a version which highlights all NPCs in range.

4.) With the latest update I focused more on fps related optimizations, so this should help to have even more NPCs. ;)

DeadmanTheGod commented 7 months ago

No Problem. i love the mod and with a few bug fixes and tweaks this will be a staple in the modpack.

  1. Yeah, the disappointment in the community manager's face when every1 can see the skins n all she could see was Steves running as saddening. Once this feature is ironed out i think the immersion level will go thru the roof.

  2. cool also noticed even with avoid water they still love water when the stroll home option is ticked .. the cat npc is known for it. I always find it in the water area under the bridge hanging with his turtle friend lol.

  3. OK , I will test the command feature when i get a chance. A cord/teleport feats would b nice just incase like in mine the npc sinks into a cave system that has been sealed away so we can go n retrieve them.

  4. I can tell. It runs super smooth even in high fps killing areas like redstone/ other entity dense areas.

  5. A small request but can you also put the change log in modrith .. CF takes forever to upload and i tend to come to github for the log but others might not know how to or use CF.

  6. How do i use the custom sound option? I want to make my npc talk. Is this update only for if someone completes an action it plays. It would b nice for the wiki to explain it. When you have time.

  7. I appreciate the updates and look forward to keep using the mod. Thank You for you hard work. :)

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.