search

MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
20 stars 8 forks source link

[Bug] NPC with custom skin via skin url only have the skin for peoples that were on the server at npc creation #166

Closed rorp24 closed 6 months ago

rorp24 commented 6 months ago

Describe the bug 🐞 We have a custom server with my gf, hopping to make a cobblemon map we could play with. We wanted to use Easy NPC to give skins to gym leaders.

As custom skin doesn't work for both of us (unless we constantly give ourself the easy NPC config, which is a solution when the map is done, but not during creation), we tried to use URL skin. And well, it was a working great... Until I decided to make some NPC when she was napping. When she came back, the NPCs were Alex skin for her.

And now, impossible for me to remove the skins and put them back so she have those too (I tried to remove them from remote cache, but it does nothing).

To Reproduce ⚙️ Steps to reproduce the behavior:

  1. create an NPC with one account
  2. Update their skin via URL
  3. Connect another account that wasn't in the world at the skin update moment.
  4. See error

Expected behavior ✔️ Everyone should be able to see the skin

Is the issue happening in combination with other mods? (If yes, please provide a full list) 🧩 here is the full list of mod we use: image

MarkusBordihn commented 6 months ago

Thanks for the report. Please activate the debug mode on both clients. See: https://github.com/MarkusBordihn/BOs-Easy-NPC/wiki/Debugging#enabling-debug-mode

After this, please perform the following steps:

The debug.log shows exactly the URL which is requested and if there are any download errors for this URL. The skins are only processed on the client, so the server is not really involved in this case at all.

URL skins have a re-try limit of once every 4-5 minutes, so if an skin download fails, it will retry the download after 4-5 minutes.

I currently testing server based skins, which eliminate such issues, but will take 2-3 weeks before they are part of an release.