search

MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
20 stars 8 forks source link

[Feature Request] Uploading custom audio for NPCs #177

Open Chris05111 opened 7 months ago

Chris05111 commented 7 months ago

I think some custom audio files for NPCs could be neat, for example custom trade sounds for successful / non successful trades. Possibly even custom audio files for spoken dialogue in game. This could improve immersion for NPCs that sound unusual with default villager noises.

MarkusBordihn commented 6 months ago

Thanks for the feedback.

Technically you can already adjust the audio over the npc.nbt file and over a command (with the next update).

Is this feature request to "upload" custom audio files from your local folder or more for the possibility to change them in general?

Chris05111 commented 6 months ago

Hi,

It was more of a suggestion to have the ability to upload your own audio files for npcs should you want to such as trading noises, good to know this option is available as is.

Thanks.

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: Markus Bordihn @.> Sent: Wednesday, May 1, 2024 11:32:19 AM To: MarkusBordihn/BOs-Easy-NPC @.> Cc: Chris05111 @.>; Author @.> Subject: Re: [MarkusBordihn/BOs-Easy-NPC] [Feature Request] Uploading custom audio for NPCs (Issue #177)

Thanks for the feedback.

Technically you can already adjust the audio over the npc.nbt file and over a command (with the next update).

Is this feature request to "upload" custom audio files from your local folder or more for the possibility to change them in general?

— Reply to this email directly, view it on GitHubhttps://github.com/MarkusBordihn/BOs-Easy-NPC/issues/177#issuecomment-2088267257, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BIFOIRRBSO44BR2BEMWOGQLZADADHAVCNFSM6AAAAABG7CQW2WVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOBYGI3DOMRVG4. You are receiving this because you authored the thread.Message ID: @.***>

dakiba commented 6 months ago

we currently use the /playaudio command to give the NPCs a voice.

https://github.com/MarkusBordihn/BOs-Easy-NPC/assets/117845495/a9e0fca4-8fa1-4938-beca-10798c19100a

DeadmanTheGod commented 6 months ago

Hopefully this feature works with distance dialog.. Imagine voice acted greetings when an npc walks by. I'm thinking of having my friends record greetings for this purpose.

github-actions[bot] commented 3 months ago

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

DeadmanTheGod commented 3 months ago

Hopefully he takes the stale tag off of this b4 it accidentally gets deleted. This is one of the features i'm waiting for. Got recordings already saved in a folder.

MarkusBordihn commented 3 months ago

Hopefully he takes the stale tag off of this b4 it accidentally gets deleted. This is one of the features i'm waiting for. Got recordings already saved in a folder.

Thank you for the note. My apologies—the stale bot automatically marks all bugs and feature requests with a 'question' label as stale. It seems that in some cases, I overlooked removing the labels.

DeadmanTheGod commented 1 month ago

question, I don't mean to rush or anything but will this feature be ready before the holiday season? I have holiday audio clips I would love to add to NPCs. If not I understand.