MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
19 stars 7 forks source link

The URL skins disappear and they do not make hand movements #188

Closed RobertoImI closed 2 months ago

RobertoImI commented 4 months ago

I'll tell you what happened, I'm working on an RPG server so I have several NPCs around the city. Many have text, trades and so on but it has happened to me that after a while the skins disappear or maybe if I update the mod or something else there is a chance that this will happen and I have to put the skin on each character again. Is this a common error?

Another thing I noticed when updating is that the character doesn't move his hands with the musical instruments in Imersive Melodies. I discovered that when you use this mod and add an instrument to the character, he starts playing and moving his hands with the instrument and since I updated it, he stops doing so. Can I do something to solve this? Or I don't know if I'm doing something wrong.

If anyone can help me, I would appreciate it and any other information you need I will gladly provide.

MarkusBordihn commented 4 months ago

Not working skins

Thanks for the feedback. Could you please "export" one of these NPCs which skin is not longer working ? In general the log on the client side should show any error and why a skin could not be loaded.

I know from other reports that there are some issues with URLs skins which could be downloaded without any issues before, but recently stopped working, because the URL skin page has added additional checks for bots and blocking the downloads now.

Not working animations

For the other issue, do you remember by any change what was the exact version were this worked ? In the recent updates I added additional support for Fabric, so I had to rewrite some of the rendering and animation parts, which maybe broke this.

RobertoImI commented 4 months ago

Thanks for your prompt response. As soon as I am home I will be passing you the images and information. If the skins are the priority, before we used skindex but loading the url does not work.

RobertoImI commented 4 months ago

01 2024-05-23_01 11 11 2024-05-23_01 11 18

Maybe that would be the thing about the animations of the hands, they no longer move them, they stay in a static position. I sent you a before and after. If not, it worked in version 3.X and I am currently using 4.3.3. Should I hold the crossbow with both hands?

MarkusBordihn commented 3 months ago

Thanks for the update. Now I fully understand the issue. With 4.x there were some performance and animation optimization to better support lower hardware.

However it seems that these mods requires the full animation without any optimization. I will try to fix this after the 5.x version is released by doing some better smart-animation and/or disable the smart-animation for specific items.

RobertoImI commented 2 months ago

Greetings, you are right, I did more tests, the error started from version 4.3.0 onwards. I was testing the versions one by one, I added 4.2.0, this is still working. Since 4.3.0, characters remain in a static potion without raising their hands. easy npc

MarkusBordihn commented 2 months ago

Thanks for the feedback. This is fixed in the upcoming beta version.

image