search

MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
20 stars 8 forks source link

[Bug] Friendly Fire Small Incompatibility #201

Closed RyoidenshiRyu closed 5 months ago

RyoidenshiRyu commented 5 months ago

💡 Check the Bug Tracker and Crash Tracker before reporting a new issue. There you can find a lot of useful information and solutions for common problems.

Note: Please make sure to fill out the following template to the best of your ability. This will help us to identify and fix the issue faster.

Describe the bug 🐞 Hello. I'm wanted to test NPC that I created with Easy NPC - Epic Fight mod support, but with Friendly Fire mod installed, owner (me) can't attack NPC without sneaking (even not all attacks are counting), but other players can. I'm thinking that issue can be reproduced with Better Combat and vanilla combat too.

To Reproduce ⚙️ Steps to reproduce the behavior:

  1. Install mods: 1) Easy NPC, 2) Easy NPC - Epic Fight support, 3) Epic Fight, 4) Friendly Fire.
  2. Launch game, create world.
  3. Create NPC.
  4. Make it attackable.
  5. Try to attack it with any weapon.
  6. See that you can't do any damage without sneaking (also there is warning on screenshot).
  7. If on server: ask your friend to attack NPC, or launch second Minecraft window with another account and attack NPC.
  8. See that other players can attack NPC without sneaking, but you (owner) can't.

Expected behavior ✔️ NPC should take damage when attacked by owner (for testing purposes).

Screenshots 📸 2024-05-22_16 58 44

Debugging 🛠️ Before reporting an issue, please enable the debug mode over /easy_npc debug true to get more detailed information about the issue in the logs. Additionally, check if there is anything relevant in the crash-reports, debug.log, and latest.log file.

Is the issue happening in combination with other mods? (If yes, please provide a full list) 🧩

Additional context 📝 I'm installed Friendly Fire only for protecting pets from accidental damage, but that mod counts NPCs that I create the same way...

MarkusBordihn commented 5 months ago

Thanks for the report. This is expected, because each NPC is owned by a player and so has an owner. It seems you could disable the protection over datapacks directly with the Friendly Fire mod itself:

Tags
This mod provides several datapack entity tags to help improve the configuration of the mod. Datapacks are a very flexible way to configure the game and allow players, servers, other mods, and modpacks to configure certain properties.

friendlyfire:bypass_pet - This is an item tag that allows items to bypass pet protections.
friendlyfire:bypass_all - This is an item tag that allows items to bypass all protections offered by the mod.
friendlyfire:general_protection - This is an entity tag that allows other mobs to be granted protection from combat damage.

However I don't see a friendlyfire:bypass_protection as entity tag or so. Please open a issue report with the Friendly Fire mod developers with your expected behavior to get their insides on this.