Closed Frogipher closed 3 months ago
MarkusBordihn
commented
3 months ago Thank you for your feedback. This feature will be very useful for managing over 340 custom skins. I haven't personally tested that many skins, so it's good to hear that everything is working well, except for the navigation.
Could you please share some of the filenames of the skins? A screenshot would be perfect. This will help us understand how the search functionality could be implemented. Thanks.
Frogipher
commented
3 months ago Hello, Markus!
I'd be happy to, below is how I name my files, searching for the names would be incredibly useful, and yes! Everything is working fine with 300+ skins! You have crafted a mod that unlike most NPC mods out there, I've been looking for one for ages and even made one myself at the time, this is great!
One other thing I would find useful is the ability to add any mob as an NPC. Currently, I have many custom entities coded into my server which are placed with no AI and a nametag, with the easy NPC placed in the same spot without a skin. I read previous requests asking for this on GitHub and I understand that this would be incredibly complicated, especially as it pertains to position and movement. One alternative that would work great for me is the current in-game command:
/easy_npc render set entity 84c73c67-62e6-40e9-8560-5b85277eb521 "minecraft :warden"
The only issue with this command is that the entity will revert back to the NPC type that was placed if you exit the chunk. For example, if I place a humanoid NPC and change the render to "warden," the NPC will visually look like a warden until I walk out of the render distance, once I re-enter, the NPC will be humanoid again. For someone like myself who is not looking for custom poses, etc, with my custom mob NPCs (I use them mainly for trading and dialogue), this command would be immensely useful if it worked.
Just a thought while I have you here! Thank you for being so responsive and I look forward to upcoming updates, great work!
[image: Screenshot 2024-07-23 at 4.18.16 AM.png]
Best, Julius R. Rodriguez (Frogipher)
On Mon, Jul 22, 2024 at 6:22 PM Markus Bordihn @.***> wrote:
Thank you for your feedback. This feature will be very useful for managing over 340 custom skins. I haven't personally tested that many skins, so it's good to hear that everything is working well, except for the navigation.
Could you please share some of the filenames of the skins? A screenshot would be perfect. This will help us understand how the search functionality could be implemented. Thanks.
— Reply to this email directly, view it on GitHub https://github.com/MarkusBordihn/BOs-Easy-NPC/issues/257#issuecomment-2243909900, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3R5DJLQQPD3R2STNBXLHCLZNWAYRAVCNFSM6AAAAABLHROCI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBTHEYDSOJQGA . You are receiving this because you authored the thread.Message ID: @.***>
MarkusBordihn
commented
3 months ago Hi Julius, thanks a lot for the detailed feedback.
That the entity will revert back to the NPC type sounds like a bug. I will create a separate bug for this and see if I could reproduce the issue.
Internally for this feature a dummy entity is created into the world, without any ai and so. My current assumption is, that some optimizer mod is removing this dummy entity when it is no longer in range. But let me test if i could reproduce the issue.
Unfortunately it seems that the screenshot is not working. :/
Frogipher
commented
3 months ago Hi Markus,
No worries, the screenshot showed a photo of my file where I keep all the skins. Here are some examples, "frog.png", " dog.png", "flower.png", "truck.png" etc, you get the idea.
On Wed, Jul 24, 2024 at 6:28 PM Markus Bordihn @.***> wrote:
Hi Julius, thanks a lot for the detailed feedback.
That the entity will revert back to the NPC type sounds like a bug. I will create a separate bug for this and see if I could reproduce the issue.
Internally for this feature a dummy entity is created into the world, without any ai and so. My current assumption is, that some optimizer mod is removing this dummy entity when it is no longer in range. But let me test if i could reproduce the issue.
Unfortunately it seems that the screenshot is not working. :/
— Reply to this email directly, view it on GitHub https://github.com/MarkusBordihn/BOs-Easy-NPC/issues/257#issuecomment-2249000380, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3R5DJKEWY4HD6MT7VFNBELZOAS73AVCNFSM6AAAAABLHROCI2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBZGAYDAMZYGA . You are receiving this because you authored the thread.Message ID: @.***>
Search bar in skin selection to easily navigate uploaded PNG skins. It can be tedious if you have hundreds of skins to scroll through to find your desired one.
I have a server where I have uploaded 340+ custom skins, and finding the desired skin is difficult. This would be so time-saving and convenient!