Closed MarkusBordihn closed 1 month ago
MarkusBordihn
commented
2 months ago @Frogipher Unfortunately, I couldn't reproduce the issue on my end. Could you please check if you are using any "optimization" mods that might be causing this problem?
Additionally, could you provide the exact Minecraft version and mod version you are using? This will help me try to reproduce the issue more accurately.
Thank you!
Frogipher
commented
2 months ago I use Embeddium only, I am using Minecraft Forge 1.20.1 with the mod version 1.20.1-4.5.1.
On Wed, Jul 24, 2024 at 6:34 PM Markus Bordihn @.***> wrote:
@Frogipher https://github.com/Frogipher Unfortunately, I couldn't reproduce the issue on my end. Could you please check if you are using any "optimization" mods that might be causing this problem?
Additionally, could you provide the exact Minecraft version and mod version you are using? This will help me try to reproduce the issue more accurately.
Thank you!
— Reply to this email directly, view it on GitHub https://github.com/MarkusBordihn/BOs-Easy-NPC/issues/259#issuecomment-2249006633, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3R5DJLXCIKCBPQHHCSBGETZOATV7AVCNFSM6AAAAABLNLTRLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENBZGAYDMNRTGM . You are receiving this because you were mentioned.Message ID: @.***>
MarkusBordihn
commented
2 months ago Thank you for the feedback. I attempted to reproduce the issue with the latest beta version 5.3.0 but was unsuccessful, even when using larger mod packs that include Embeddium.
Could you please check if the issue persists with the latest beta 5.3.0? I have made several changes to the "Custom Models" since version 4.5.1, so it is possible that this specific issue has already been resolved.
MarkusBordihn
commented
2 months ago During my testing of version 1.20.6, I was able to reproduce the issue. It appears to be a vanilla behavior that removes the "dummy" entity from the chunk, and it is not related to any other mod.
I will work on a fix to detect when a "dummy" entity is removed and re-create it if necessary.
Frogipher
commented
2 months ago That would be great! Thank you, Markus!
On Sat, Jul 27, 2024 at 4:26 PM Markus Bordihn @.***> wrote:
During my testing of version 1.20.6, I was able to reproduce the issue. It appears to be a vanilla behavior that removes the "dummy" entity from the chunk, and it is not related to any other mod.
I will work on a fix to detect when a "dummy" entity is removed and re-create it if necessary.
— Reply to this email directly, view it on GitHub https://github.com/MarkusBordihn/BOs-Easy-NPC/issues/259#issuecomment-2254246066, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3R5DJPBMMTYUCYBNMK2YKTZOP655AVCNFSM6AAAAABLNLTRLKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJUGI2DMMBWGY . You are receiving this because you were mentioned.Message ID: @.***>
MarkusBordihn
commented
1 month ago Seems I was able to fix the issues and improved the general custom model support. To make tests easier, I added a custom model select screen, which will get a search bar as well and will look like:
This should allow to easily select custom models.
Need to run some tests with bigger mod packs and if there are no issues, this will be part of the next beta.
Frogipher
commented
1 month ago This is incredibly helpful, thank you, Markus!
On Fri, Aug 2, 2024 at 4:17 PM Markus Bordihn @.***> wrote:
Closed #259 https://github.com/MarkusBordihn/BOs-Easy-NPC/issues/259 as completed via efc085b https://github.com/MarkusBordihn/BOs-Easy-NPC/commit/efc085b7b01149d16138a5bc2317c00f9d6f7def .
— Reply to this email directly, view it on GitHub https://github.com/MarkusBordihn/BOs-Easy-NPC/issues/259#event-13746369590, or unsubscribe https://github.com/notifications/unsubscribe-auth/A3R5DJOIDUMIZDGTIOPCVQLZPPSPLAVCNFSM6AAAAABLNLTRLKVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJTG42DMMZWHE2TSMA . You are receiving this because you were mentioned.Message ID: @.***>
One alternative that would work great for me is the current in-game command:
/easy_npc render set entity 84c73c67-62e6-40e9-8560-5b85277eb521 "minecraft :warden"
The only issue with this command is that the entity will revert back to the NPC type that was placed if you exit the chunk. For example, if I place a humanoid NPC and change the render to "warden," the NPC will visually look like a warden until I walk out of the render distance, once I re-enter, the NPC will be humanoid again. For someone like myself who is not looking for custom poses, etc, with my custom mob NPCs (I use them mainly for trading and dialogue), this command would be immensely useful if it worked.