MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
19 stars 7 forks source link

[Feature Request] Automatic detect and correct invalid image formats #261

Closed Popcornboy333 closed 2 months ago

Popcornboy333 commented 2 months ago

šŸ’” Check the Bug Tracker and Crash Tracker before reporting a new issue. There you can find a lot of useful information and solutions for common problems.

Note: Please make sure to fill out the following template to the best of your ability. This will help us to identify and fix the issue faster.

Minecraft and Mod version šŸž 1.18.2

Describe the bug šŸž I tried using a url for a fisherman skin I got from a website called the Skindex, but when I pasted the skin link into the URL bar, it told me to wait while it processed it, then that text disappears but there's still no skin. I even tried using the cusom skin tab by downloading the fisherman skin and putting it in the same folder as the template skin, but it doesn't show up.

To Reproduce āš™ļø Steps to reproduce the behavior:

  1. Go to 'https://www.minecraftskins.com/skin/22657097/fisherman/'
  2. Click on 'Image Link'
  3. In Minecraft, paste the Image Link
  4. Click on "Add"
  5. See error

Expected behavior āœ”ļø I expected the skin to be added onto the steve npc but it wasn't

image image

Is the issue happening in combination with other mods? (If yes, please provide a full list) šŸ§©

alexs delight alexs mobs appleskin aquaculture aquamirae aquatictorches architectury awesomedungeonocean better chunckloading better compatibility checker better fps distance biome music biomes o plenty blueprint caelus chipped citadel clickable advancements clumps collective comforts connectivity controlling copycats corpse crabbers delight create central kitchen create create diesel generators cristellib ctm cupboard curios dark waters deeper oceans deuf easy npc effective embeddium endless ocean entity model features entity texture features essential eureka everything is copper farmers delight fast async world save ferrite core fps monitor ftb chunks ftb library ftb quests ftb teams fusion geckolib gpu memory leak fix guard villagers higher world deeper oceans hop better ruined portals hop better underwater ruins hourglass interiors item filters jade jeed jei just enough breeding just enough resources kiwi kotlin for forge labels lazy dfu let me despawn library ferret lottr mcw bridges mcw doors mcw fences mcw furniture mcw holidays mcw lights mcw paintings mcw paths mcw roofs mcw trapdoors mcw windows meed memory settings miners delight modernfix mouse tweaks natures compass nether depths upgradenot enough animations obscure api obsidian ui ocean recovery ocean expansion ocean floor oceans delight ocean worlds oculus ore tweaker packet fixer passable foliage polymorph presence footsteps randomium real m rpg seadwellers rechiseled chipped rechiseled rechiseled create river treasures ryoamic lights scuba gear selene serene seasons smooth chunk snow real magic snow under strees sophisticated backpacks sophisticated core sound physics spark structure essentials supermartijn 642configlib supermartijn642corelib supplementaries terrablender treechop treechop jade treeplant upgrade aquatic valkyrien skies water strainer world data loader worldedit xaeros minimap xaeros worldmap yungs api yungs better desert temples yungs better dungeons yungs better end island yungs better mineshafts yungs better nether fortreesses yungs better ocean monuments yungs better strongholds yungs better witch huts yungs bridges yungs extras

MarkusBordihn commented 2 months ago

Thanks a lot for the report, in this case the used image is "broken".

By taking a look into the file you see the following: image

This means even if the image seems to be a .png file it's in fact a .webp file which could not be processed from Minecraft itself.

I will convert this into a feature request to see if I could automatically detect such issues and covert them to a .png and/or giving a better error message.

If you open the file in a image editor e.g. "paint" and re-save it as .png, the image will working fine as skin.

MarkusBordihn commented 2 months ago

Unfortunately, automatically converting images would require additional packages totaling around 1.2 MB. This would nearly double the size of the mod itself, so I have decided not to implement automatic conversion.

However, I have added a pre-check feature that will warn you about any images that cannot be processed.