MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
19 stars 7 forks source link

[Bug] trading screen command #335

Closed EvilMask587 closed 1 day ago

EvilMask587 commented 1 week ago

Minecraft and Mod version 🐞 forge 1.20.1 and mod 5.6.0

Describe the bug 🐞 Hi, i have a problem on my server with this mod, im install dialogues system and trying to open trading screen in this mod, but players [14:26:31] [Server thread/ERROR] [Easy NPC/]: [d4166b57-cde1-49f1-84e5-13667783f289:ServerPlayer['KseroCD'/7289, l='ServerLevel[world]', x=71.06, y=123.00, z=-64.94]] Player has no permission to access Humanoid['Мол'/39022, l='ServerLevel[world]', x=71.50, y=123.00, z=-64.50]! [14:26:31] [Server thread/ERROR] [Easy NPC/]: [Access denied] Player ServerPlayer['KseroCD'/7289, l='ServerLevel[world]', x=71.06, y=123.00, z=-64.94] tried to access EasyNPC with UUID d4166b57-cde1-49f1-84e5-13667783f289!

Expected behavior βœ”οΈ when player write command they open the trading screen of npc from dialogue

Screenshots πŸ“Έ image

Is the issue happening in combination with other mods? (If yes, please provide a full list) 🧩 Blabber

Additional context πŸ“ Add any other context about the problem here.

MarkusBordihn commented 1 week ago

Thank you for the report. Could you please provide more details on how the command is being triggered?

If the command is being triggered by Blabber, this behavior is expected. Blabber executes commands as the player, not as the NPC or another entity.

According to the Blabber wiki: ... commands run from dialogue actions and commands run through execute as <player> ...

Reference: Blabber Documentation

This means you need to ensure that the command is executed as either an NPC or a player with the appropriate permissions. Dialogue commands are restricted to NPCs, their owners, Command Blocks, Functions, and OPs, to prevent players from exploiting the system by forcefully opening NPC dialogues.

In this case, I am unable to detect whether the command was executed by Blabber or if the source is a legitimate player.

github-actions[bot] commented 5 days ago

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

github-actions[bot] commented 1 day ago

This issue was closed because it has been stalled for 5 days with no activity.