MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
20 stars 8 forks source link

[Feature Request] NPCs that use player skin should have dynamic skin changing #360

Closed pantsguyapp closed 3 weeks ago

pantsguyapp commented 1 month ago

💡 Check the Wiki and Feature Request Tracker before reporting a feature request. There you can find a lot of useful information and solutions for common problems.

Is your feature request related to a problem? Please describe. 🤔 A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] When the npc is wearing a player's skin, the skin won't get changed even if the player themself change their skin

Describe the solution you'd like 💭 A clear and concise description of what you want to happen. Dynamic skin detection upon chunk reload/relogging to detect if the player has changed their skin to make the npc change their player skin.

Describe alternatives you've considered 🔄 A clear and concise description of any alternative solutions or features you've considered. None, above is literally the only solution.

Additional context 📝 Add any other context or screenshots about the feature request here.

pantsguyapp commented 1 month ago

You can test this out by having the NPC applying your skin then you change that skin, wait for the system to update your action then log into the game to see if the NPC also change its skin.

MarkusBordihn commented 1 month ago

Thank you for the report. However, this behavior is intentional. Since skins are only processed on the client side, they are cached to avoid repeatedly requesting and processing the same skin for the same NPCs. The server only stores the username associated with the skin, as the Mojang API does not provide a skin history.

If you delete your local cache directory, you will see the latest skin.

I could add a configuration option to allow re-validation of skins after a set period (like 1 day), but real-time re-validation would result in excessive requests to the Mojang API.

If you have any other ideas or suggestions, feel free to share them!

pantsguyapp commented 1 month ago

Still, can this be an option in the config for someone who enjoy putting player skins on NPCs to see random skin changes throughout the day.

github-actions[bot] commented 1 month ago

This issue is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 3 days.

github-actions[bot] commented 3 weeks ago

This issue was closed because it has been stalled for 5 days with no activity.