search

MarkusBordihn / BOs-Easy-NPC

Create easily NPC for your world or for your mod.
Other
19 stars 7 forks source link

Drowned and turtle can't breath under water. Smite dosen't work against zombies. #365

Open Sixdition opened 6 days ago

Sixdition commented 6 days ago

💡 Check the Bug Tracker and Crash Tracker before reporting a new issue. There you can find a lot of useful information and solutions for common problems.

Note: Please make sure to fill out the following template to the best of your ability. This will help us to identify and fix the issue faster.

Minecraft and Mod version 🐞 Minecraft 1.21.1 NeoForge 21.1.66 EasyNpc 5.7.1

Describe the bug 🐞 1.Drowned and turtle can't breath under water. 2.Zombie can't turn to drowned under water. 3.Smite dosen't work against zombies.

To Reproduce ⚙️ Steps to reproduce the behavior:

  1. Enter game
  2. Gamemode Creative
  3. Put drowned in water and wait
  4. Drowned die

Expected behavior ✔️ These bugs do not appear in Minecraft version 1.19 and will appear in 1.20 and 1.21

Screenshots 📸 If applicable, add screenshots to help explain your problem.

Debugging 🛠️ Before reporting an issue, please enable the debug mode over /easy_npc debug true to get more detailed information about the issue in the logs. Additionally, check if there is anything relevant in the crash-reports, debug.log, and latest.log file.

Is the issue happening in combination with other mods? (If yes, please provide a full list) 🧩 No other mods

Additional context 📝 Add any other context about the problem here.

MarkusBordihn commented 6 days ago

Thank you for the report. However, it seems there’s a bit of a misunderstanding about what an NPC is.

An NPC is not a 1:1 copy of existing entities with the same logic, abilities, and goals. For example, it’s expected that NPC zombies won’t transform into drowned, and certain weapons may not have the same effects on NPCs as they do on regular entities.

Adding all the logic, abilities, and goals of regular entities to NPCs would make it difficult to maintain performance, especially when many NPCs are present on a server or in a game.

In the next update, there will be an option to enable 'can breathe underwater' for each NPC. I’ll also take a closer look at the effects and potentially add them.

However, when you choose a different 'model' like 'Turtle,' only the appearance of the NPC changes, not its behavior or abilities. For instance, if a zombie NPC is spawned and then displayed as a 'Turtle,' it should already be able to breathe underwater.

Sixdition commented 6 days ago

Sorry for my unclear expression. When I mention "zombie" and "drowned", I am not referring to the "NPC zombie" and "NPC drowned" in the "easy NPC mod", but to the naturally generated creatures in the game. In addition, in 1.19.4, after installing easy NPC mod, drowned can breathe underwater. This bug appeared in 1.21.1 and 1.20+.

Sixdition commented 6 days ago

2024-10-20_19 05 07 2024-10-20_19 05 18

MarkusBordihn commented 5 days ago

Thank you for the clarification. However, there are no references in the code that modify vanilla entities.

For example, with Drowned:

And with Zombies:

There are a few references to zombies in the code, but only to inherit their attributes for the new 'Epic Fight' integration.

Therefore, I don’t see any direct connection between the reported issue and the Easy NPC mod, especially for 'Drowned,' where there are no references in the code at all.

Sixdition commented 5 days ago

Thanks for the reply, maybe there are other reasons that caused this bug. I love your mod very much and hope that one day I can find a solution to this bug.