Cant change config .toml

cyrok commented 1 year ago

config is always wrong when i try to modify. copy protection let the server crash and even removing just the text thats marked with # infront, it says config is invalid.

[19:01:19] [Thread-0/WARN] [ne.mi.fm.co.ConfigFileTypeHandler/CONFIG]: Configuration file H:\FORGE SERVER\Minecraft Forge Server 1.19\config\lobby-common.toml is not correct. Correcting 1.19 forge with lobby 0.5.2

going back to 0.5.1 havent solved it

MarkusBordihn commented 1 year ago

Could you please add a full crash log for the server crash and an example of your modified config ?

Removing the existing comments will force a config correction, by default. But only changing the values should not trigger something like this.

cyrok commented 1 year ago

latest.log thats my latest log, still running rn. even values or changing from true to flase sadly triggers that. removing the comments was just a try

MarkusBordihn commented 1 year ago

Thanks for the logs, looks very strange like:

[26Juli2022 19:07:03.709] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Configuration file H:\FORGE SERVER\Minecraft Forge Server 1.19\config\lobby-common.toml is not correct. Correcting
[26Juli2022 19:07:03.709] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Default Dimension.defaultDimensionName was corrected from Spawn to its default, null. 
[26Juli2022 19:07:03.710] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Default Dimension.defaultCommandPermissionLevel was corrected from 0 to its default, null. 
[26Juli2022 19:07:03.710] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Lobby Dimension.lobbyDimensionName was corrected from Lobby to its default, null. 
[26Juli2022 19:07:03.710] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Lobby Dimension.lobbyCommandPermissionLevel was corrected from 0 to its default, null. 
[26Juli2022 19:07:03.711] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Mining Dimension.miningDimensionName was corrected from Mining to its default, null. 
[26Juli2022 19:07:03.711] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Mining Dimension.miningCommandPermissionLevel was corrected from 0 to its default, null. 
[26Juli2022 19:07:03.711] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Mining Dimension.miningRemoveLootChest was corrected from true to its default, null. 
[26Juli2022 19:07:03.711] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Fishing Dimension.fishingDimensionName was corrected from Fishing to its default, null. 
[26Juli2022 19:07:03.712] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Fishing Dimension.fishingCommandPermissionLevel was corrected from 0 to its default, null. 
[26Juli2022 19:07:03.712] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Gaming Dimension.gamingDimensionName was corrected from Gaming to its default, null. 
[26Juli2022 19:07:03.712] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Gaming Dimension.gamingCommandPermissionLevel was corrected from 0 to its default, null. 
[26Juli2022 19:07:03.712] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Void Dimension.voidDimensionName was corrected from Void to its default, null. 
[26Juli2022 19:07:03.713] [main/WARN] [net.minecraftforge.common.ForgeConfigSpec/CORE]: Incorrect key Void Dimension.voidCommandPermissionLevel was corrected from 0 to its default, null.

Basically the log says that it changed everything to "null", but there is no "null" definition in the config file at all, see: https://github.com/MarkusBordihn/BOs-Lobby/blob/main/src/main/java/de/markusbordihn/lobby/config/CommonConfig.java

This means there is something wrong with the server or with the mods your are using.

Besides of this I'm not really able to reproduce the issue from my side even with the same version 41.0.111.

I will release an update with a strict UTF-8 encoding, maybe this will solve the issue. If not I would need some more details about the used server and mod pack to be able to reproduce the issue.

MarkusBordihn commented 1 year ago

Should be live in the next minutes over https://www.curseforge.com/minecraft/mc-mods/lobby/files/3900869

cyrok commented 1 year ago

grafik here is the modlist. sadly id doesnt solved the issue. any toher information i can send you? i would be able to send you more information. there are datapacks too, i forgot... i can upload the datapacks and mod files in one part, if this helps?

MarkusBordihn commented 1 year ago

Thanks for the feedback. Let first check if this is an issue with the mod pack or something else. Please try to run the mod without any other mods / datapacks to see if your server runs correct.

If you still get the same issue, it's seems related to the server and not the modpack or datapacks.
If you not get any issue, it's seems related to the modpack or datapacks.

cyrok commented 1 year ago

so, sorry for my late response. i tryed without mods, only lobby, tryed with a new world (no datapacks) still the same issue latest.log

cyrok commented 1 year ago

im not of a big help in regards to coding, i just try to find out why it wont let me change it at all. trying to ad a copy protection over the config will end in a crashing server... i will upload my server now, mby this will help? i tried with a new map, still the same... only lobby and no datapacks.... i got no idea... here is my server, mby it helps? (no map, to make it smaller) [Removed server file]

cyrok commented 1 year ago

can you tell me something abbout this? i cant find any good information why i get that... grafik

MarkusBordihn commented 1 year ago

Thanks for the feedback and the details. Unfortunately there is something strange which your server files like:

The library directory is too big in size
There is a server.jar file (there should none)

I recommend the following steps to fix the server files:

Create a backup
Delete the library folder
Delete the server.jar file
Install the latest forge server version
Make sure you only start the server over the .bat or .sh file and not over any .jar file
Make sure you have an up-to-date Java 17 installed

For the mod specific issue, please try the following:

Make sure the server is not running
Delete the existing config file
Start the server
Stop the server (new file should be created)
Modify the file (share the file here) with a good editor like VSCode (https://code.visualstudio.com/)
Start the server again and check if you still run into the issue.

I was able to adjust the config without any issues after performing the above steps with your server files.

Regarding your latest issue This is hard to say normally it means that you exceed some network limit (too many mods, too many data), some of them could be fix with mods like: https://www.curseforge.com/minecraft/mc-mods/connectivity others are harder to fix.

cyrok commented 1 year ago

aaaaaahhh allright, it looks like its my own fault. configs arent changeable for some mods, when the server runs, how it looks.

and the mod you recommended helped me allot here, thanks allot <3

MarkusBordihn commented 1 year ago

Great to hear that the issue is resolved. Yeah there are some mods which needs the information before the world is loading in most cases everything which is related to dimensions, structures or biomes.

If you plan to build your own mod pack feel free to take a look at https://www.curseforge.com/minecraft/modpacks/bos-adventure-world for some additionally helpful and interesting mods.

MarkusBordihn / BOs-Lobby

Cant change config .toml #10