MarkusBordihn / BOs-Mods-Optimizer

Automatic and realtime server bundling (one mod pack for client/server) and mod clean up for better performance and less crashes.
Other
3 stars 2 forks source link

HopoBetterRuinedPortals causing crash with invalid JSON. #17

Closed Krimatoria closed 4 months ago

Krimatoria commented 4 months ago

Forge 43.3.5

[15:26:18] [main/ERROR] [Mods Optimizer/]: Was unable to read mods file fabric.mod.json from C:\Users****\Downloads\MultiMC\MultiMC\instances\1.19.2.minecraft\mods\HopoBetterRuinedPortals-[1.19-1.19.3]-1.3.3.jar: com.google.gson.JsonSyntaxException: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 15 column 2 path $ at com.google.gson.JsonParser.parseReader(JsonParser.java:66) ~[gson-2.8.9.jar%2394!/:?] {} at de.markusbordihn.modsoptimizer.data.ModFileParser.parseFabricModFile(ModFileParser.java:488) ~[?:?] {} at de.markusbordihn.modsoptimizer.data.ModFileParser.parseMixedModFile(ModFileParser.java:164) ~[?:?] {} at de.markusbordihn.modsoptimizer.data.ModFileParser.parseModFile(ModFileParser.java:137) ~[?:?] {} at de.markusbordihn.modsoptimizer.data.ModData.readModInfo(ModData.java:258) ~[?:?] {} at de.markusbordihn.modsoptimizer.data.ModData.readModInfo(ModData.java:231) ~[?:?] {} at de.markusbordihn.modsoptimizer.data.ModData.parseMods(ModData.java:81) ~[?:?] {} at de.markusbordihn.modsoptimizer.service.ModsOptimizerService.parseMods(ModsOptimizerService.java:157) ~[?:?] {} at de.markusbordihn.modsoptimizer.services.ModLocatorService.(ModLocatorService.java:61) ~[?:?] {} at jdk.internal.reflect.DirectConstructorHandleAccessor.newInstance(Unknown Source) ~[?:?] {} at java.lang.reflect.Constructor.newInstanceWithCaller(Unknown Source) ~[?:?] {} at java.lang.reflect.Constructor.newInstance(Unknown Source) ~[?:?] {} at java.util.ServiceLoader$ProviderImpl.newInstance(Unknown Source) ~[?:?] {} at java.util.ServiceLoader$ProviderImpl.get(Unknown Source) ~[?:?] {} at cpw.mods.modlauncher.util.ServiceLoaderUtils.lambda$streamWithErrorHandling$0(ServiceLoaderUtils.java:39) ~[modlauncher-10.0.8.jar%23109!/:?] {} at java.util.stream.ReferencePipeline$3$1.accept(Unknown Source) ~[?:?] {} at java.util.ServiceLoader$ProviderSpliterator.tryAdvance(Unknown Source) ~[?:?] {} at java.util.Spliterator.forEachRemaining(Unknown Source) ~[?:?] {} at java.util.stream.AbstractPipeline.copyInto(Unknown Source) ~[?:?] {} at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) ~[?:?] {} at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(Unknown Source) ~[?:?] {} at java.util.stream.AbstractPipeline.evaluate(Unknown Source) ~[?:?] {} at java.util.stream.ReferencePipeline.collect(Unknown Source) ~[?:?] {} at net.minecraftforge.fml.loading.moddiscovery.ModDiscoverer.(ModDiscoverer.java:45) ~[fmlloader-1.19.2-43.3.5.jar%23122!/:?] {} at net.minecraftforge.fml.loading.FMLLoader.beginModScan(FMLLoader.java:165) ~[fmlloader-1.19.2-43.3.5.jar%23122!/:1.0] {} at net.minecraftforge.fml.loading.FMLServiceProvider.beginScanning(FMLServiceProvider.java:86) ~[fmlloader-1.19.2-43.3.5.jar%23122!/:1.0] {} at cpw.mods.modlauncher.TransformationServiceDecorator.runScan(TransformationServiceDecorator.java:112) ~[modlauncher-10.0.8.jar%23109!/:?] {} at cpw.mods.modlauncher.TransformationServicesHandler.lambda$runScanningTransformationServices$8(TransformationServicesHandler.java:100) ~[modlauncher-10.0.8.jar%23109!/:?] {} at java.util.stream.ReferencePipeline$3$1.accept(Unknown Source) [?:?] {} at java.util.HashMap$ValueSpliterator.forEachRemaining(Unknown Source) [?:?] {} at java.util.stream.AbstractPipeline.copyInto(Unknown Source) [?:?] {} at java.util.stream.AbstractPipeline.wrapAndCopyInto(Unknown Source) [?:?] {} at java.util.stream.AbstractPipeline.evaluate(Unknown Source) [?:?] {} at java.util.stream.AbstractPipeline.evaluateToArrayNode(Unknown Source) [?:?] {} at java.util.stream.ReferencePipeline.toArray(Unknown Source) [?:?] {} at java.util.stream.ReferencePipeline.toArray(Unknown Source) [?:?] {} at java.util.stream.ReferencePipeline.toList(Unknown Source) [?:?] {} at cpw.mods.modlauncher.TransformationServicesHandler.runScanningTransformationServices(TransformationServicesHandler.java:102) [modlauncher-10.0.8.jar%23109!/:?] {} at cpw.mods.modlauncher.TransformationServicesHandler.initializeTransformationServices(TransformationServicesHandler.java:55) [modlauncher-10.0.8.jar%23109!/:?] {} at cpw.mods.modlauncher.Launcher.run(Launcher.java:87) [modlauncher-10.0.8.jar%23109!/:?] {} at cpw.mods.modlauncher.Launcher.main(Launcher.java:77) [modlauncher-10.0.8.jar%23109!/:?] {} at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-10.0.8.jar%23109!/:?] {} at cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-10.0.8.jar%23109!/:?] {} at cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:141) [bootstraplauncher-1.1.2.jar:?] {} at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source) ~[?:?] {} at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?] {} at io.github.zekerzhayard.forgewrapper.installer.Main.main(Main.java:67) [ForgeWrapper-mmc4.jar:mmc4] {} at jdk.internal.reflect.DirectMethodHandleAccessor.invoke(Unknown Source) ~[?:?] {} at java.lang.reflect.Method.invoke(Unknown Source) ~[?:?] {} at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:196) [NewLaunch.jar:?] {} at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:231) [NewLaunch.jar:?] {} at org.multimc.EntryPoint.listen(EntryPoint.java:143) [NewLaunch.jar:?] {} at org.multimc.EntryPoint.main(EntryPoint.java:34) [NewLaunch.jar:?] {} Caused by: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 15 column 2 path $ at com.google.gson.stream.JsonReader.syntaxError(JsonReader.java:1562) ~[gson-2.8.9.jar%2394!/:?] {} at com.google.gson.stream.JsonReader.checkLenient(JsonReader.java:1403) ~[gson-2.8.9.jar%2394!/:?] {} at com.google.gson.stream.JsonReader.doPeek(JsonReader.java:541) ~[gson-2.8.9.jar%2394!/:?] {} at com.google.gson.stream.JsonReader.peek(JsonReader.java:424) ~[gson-2.8.9.jar%2394!/:?] {} at com.google.gson.JsonParser.parseReader(JsonParser.java:61) ~[gson-2.8.9.jar%2394!/:?] {} ... 52 more

MarkusBordihn commented 4 months ago

Thanks a lot or the report. In this case the error is caused by HopoBetterRuinedPortals HopoBetterRuinedPortals-[1.19-1.19.3]-1.3.3.jar itself. Their fabric.mod.json is invalid which seems to be fixed in newer versions.

image

I will implement an extra check so that the mod is not crashing for this kind of errors from other mods.

Additionally I added a post for the mod author per Discord so that this get fixed on their side.

MarkusBordihn commented 4 months ago

Good news Hopo will fix this error and will release an updated version in the next hours. 👍

Krimatoria commented 4 months ago

Хорошие новости: Hopo исправит эту ошибку и выпустит обновленную версию в ближайшие часы. 👍

Nice))))))))