search

MarkusH / django-osm-field

http://markush.github.io/django-osm-field
MIT License
29 stars 12 forks source link

feat: support Django 1.11, 2.2 and 3.0 #18

Closed galuszkak closed 4 years ago

galuszkak commented 4 years ago

Hi @MarkusH ,

Thanks for creating this package and contributing this package to python community. Really appreciate that!

I know you aren't supporting this package anymore but we are still using it (see here: https://oswiecimdziejesie.pl/wydarzenie/4508/ ) and it is really good package for someone who doesn't have access to any GeoDjango features like PostGIS.

Therefore I would like to ask, would you be willing to maybe give us (people from Hackerspace Silesia or me) permissions to release new packages and merging rights (or transfer repository to us?).

Here is our contribution with support for only Python 3 and Django 1.11 and 2.2 and 3.0

Thanks!

codecov-io commented 4 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (develop@00e6613). Click here to learn what that means. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop      #18   +/-   ##
==========================================
  Coverage           ?   92.71%           
==========================================
  Files              ?        4           
  Lines              ?      151           
  Branches           ?       16           
==========================================
  Hits               ?      140           
  Misses             ?        5           
  Partials           ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 00e6613...7cdb3e2. Read the comment docs.

netAction commented 4 years ago

I don't know what to do here as I am no Django developer. @saschan? @MarkusH? Could you help?

MarkusH commented 4 years ago

Hi @galuszkak. Thank you for your offer. I'll think about how to proceed.

galuszkak commented 4 years ago

Hi @MarkusH ,

Thank you for taking this into consideration. Appreciated that! Let me know how you would want to move forward.

MarkusH commented 4 years ago

Hi @galuszkak. Thanks for bearing with me. There are thre options, from my perspective:

  1. You use your own fork and own PyPI package.
  2. You use your own fork and I hand over the PyPI namespace to you.
  3. We get the package into a state that it can be moved to @jazzband.

I'm fine with any of those. Take your pick :slightly_smiling_face:

galuszkak commented 4 years ago

@MarkusH I'm fine with moving to @jazzband . My understanding that when this happens we have all things automated and anyone who is interested can maintain that, which is think best for community, not only me :) .

galuszkak commented 4 years ago

Hi @MarkusH,

Is there anything that I can do to help with that transition?

Thanks!

MarkusH commented 4 years ago

Merged with #19

MarkusH commented 4 years ago

Since Django 1.11 is out of support, I dropped (official) support for that.

MarkusH commented 4 years ago

And version 0.4.0 is out.

galuszkak commented 4 years ago

@MarkusH when I did PR, it was still in support as it support expired in 1st of April 2020 ;)

MarkusH commented 4 years ago

Yes, it was, indeed.