search

MarkusTheOrt / F1TVUnofficial

17 stars 6 forks source link

New version #2

Open bkonings opened 4 years ago

bkonings commented 4 years ago

Had a look at the new version, seems nice, however some parts are not implemented it seems. Most obvious the Library and Season selection are empty. I guess this is a work in progress?

Just a suggestion btw: add //MARK Comments to make the source code look better in the Xcode minimap :)

Lastly my real Apple TV does not seem to load any content while the simulator does, still trying to debug that but not sure what is happening there.

Thanks again for your app, still sad you where unable to make a official release in the app store :|\ Keep up the good work!

MarkusTheOrt commented 4 years ago

You‘re right, the library and season tabs are work in progress. I‘ve never tried running the new version on my AppleTV but I am fairly certain that if you add request.addValue("en-en", forHTTPHeaderField: "accept-language") this to every request the api should respond with content, for some reason the simulator doesn’t set the header for language.

Still much work to be done but I have my plate full of more important stuff lately so there’s not much progress. I am however still working on it, just slowly.

Oh and I will definitely use the mark comments going forward :-)

bkonings commented 4 years ago

I'll have a look at the language suggestion, my guess is my Apple TV is set to a language other then English ;)

MarkusTheOrt commented 4 years ago

Mine is German by default although there is translated content on F1TV it just doesn’t give me any results. Weird stuff. Anyways if English is the default Lang of your device and it doesn’t show anything, try adding the header as I suggested (and I know this is way too recursive to do)