search

Marlamin / WoWFormatTest

Several applications that I use to interact with various file formats WoW uses
https://wow.tools
MIT License
69 stars 19 forks source link

A few additions to OBJExporterUI #42

Closed dkrutsko closed 7 years ago

dkrutsko commented 7 years ago

Hey, I recently discovered your OBJExporterUI project and became an instant fan, very nice work! I spent the past weekend playing around with WoW assets and extending your code with some features I needed. I'm opening this issue in case you were interested in integrating some of these changes back into your project.

The first change I made is I added the ability to export M2 collision models alongside exported .obj files. These new .phys.obj files contain the model WoW uses for calculating collision.

The second change I made is I added support for ADT holes. Although I might have cheated a bit (I just omit the face declarations in the outputted OBJ that are holes), it seems to work fairly well. My version supports both the new "high-resolution" holes as well as the old "low-resolution" ones. I haven't tested the low-resolution one because I couldn't find a map that uses them. Perhaps they're all using high-resolution ones and the low-resolution code is no longer needed?

The third change I made is I removed the "# Written by Marlamin comments in the OBJ files because they seem to have broke my 3D applications' OBJ importer (Autodesk Softimage 2012). I'm thinking that it's interpreting face vertices based on line number rather than declared occurrence?? Regardless, removing that line fixed my problems.

Thanks again for your hard work and I look forward to seeing the new features! Let me know if you need pull requests for any of these changes and to what branch. Also I haven't written C# in 7 years so forgive my crappy code, I mainly use C++ and JavaScript.

Marlamin commented 7 years ago

Wow, this is some pretty awesome work! I didn't expect people from the community to make changes, especially stuff like ADT holes and .phys. And this code looks fine, much better than most of my code even. If you could open up a pull request with these changes I'd be happy to merge them, I'm also happy to do it myself, but thought you might want to do it. Thanks again!

dkrutsko commented 7 years ago

Sounds good, I'll go ahead and get those opened. Please modify the code to suit your needs. I'll omit the third change for now because I think there's a better way of fixing it through group and object declarations, not sure though.

Marlamin commented 7 years ago

Merged! Thanks again!