Marlamin / WoWFormatTest

Several applications that I use to interact with various file formats WoW uses
https://wow.tools
MIT License
69 stars 19 forks source link

16k Split Files, Non-Uniform Lighting & Texture stitching. #67

Closed reddohme closed 6 years ago

reddohme commented 6 years ago

An issue I've noticed is with 16k textures coming from split files is that their lighting and stitching could vary between tile. Example using Broken Isles Trueshot Lodge (trollraid_22_23.adt) export and photoshop to put them together. image

Is it possible at all to make it so that there is an optional setting to not split the file?

Marlamin commented 6 years ago

Are you sure this only happens on 16k? I feel like I've seen this issue on all baked textures. As for not splitting the file, it's kind of required if we want to stick to that resolution (hardware limits). You can however select a lower quality baked texture which would be a single file.

reddohme commented 6 years ago

My mistake, actually. Looking at the 8k preview the inconsistency is there as well! I'm sorry for not looking into more detail before making an issue report!

I'll continue to look into my depth at the stuff I've seen. So far I've noticed blender importing objects (or the adt mesh) not on the proper position. I've fixed this in Unity with adjusting the terrain mesh. I'm unsure if it's my own issue or widespread. I can create another issue topic if you'd like.

Marlamin commented 6 years ago

Probably more widespread, I've noticed it myself. Feel free to make another issue, I was going to look into it soonish anyways.

On Sun, Mar 4, 2018, 12:53 reddohme notifications@github.com wrote:

My mistake, actually. Looking at the 8k preview the inconsistency is there as well! I'm sorry for not looking into more detail before making an issue report!

I'll continue to look into my depth at the stuff I've seen. So far I've noticed blender importing objects (or the adt mesh) not on the proper position. I've fixed this in Unity with adjusting the terrain mesh. I'm unsure if it's my own issue or widespread. I can create another issue topic if you'd like.

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/Marlamin/WoWFormatTest/issues/67#issuecomment-370223055, or mute the thread https://github.com/notifications/unsubscribe-auth/AADEJOQ9samUTWYOTlX_1Kp-9GuFRtm2ks5ta9W7gaJpZM4SbSmo .

Marlamin commented 6 years ago

An upcoming version should improve this significantly, @CucFlavius found a typo in the shader which should get rid of the non-uniformity.

Difference Difference (zoomed in)

reddohme commented 6 years ago

Hell yeah dude, you're powerful

Marlamin commented 6 years ago

This improvement shipped in the new version.

Feel free to close the issue if the problem is resolved for you, if not please let me know.