search

Marlamin / WoWFormatTest

Several applications that I use to interact with various file formats WoW uses
https://wow.tools
MIT License
69 stars 19 forks source link

DBCDump issue with new lines in resulting CSV #86

Closed Rokeo closed 5 years ago

Rokeo commented 5 years ago

Hi there! Thank you for your awesome tool.

I have issue with exporting tables which have new lines, it do export to csv exactly as new line, than as symbol like \n, which cause problems for parsing - as now row not exactly a line anymore

here is example of table which have this issue https://bnet.marlam.in/dbc.php?dbc=spell.db2

here is a screenshot what i mean: image

Rokeo commented 5 years ago

Also can you change the way it do naming for heading?

Currently it do it like this: ID,DisplayName_lang,DisplayNameShort_lang,Flags,RangeMin[0],RangeMin[1],RangeMax[0],RangeMax[1] so we have those weird names for arrays: RangeMax[0] and ,RangeMax[1] it would be much better if it named it instead like RangeMax_1 and RangeMax_2

Thanks!

Rokeo commented 5 years ago

p.s. if it possible to update database dumper to retail 8.1 build 28807?

Marlamin commented 5 years ago

I think CSV having newlines inside rows is valid as long as they're inside a string, it's up to the CSV importer to implement this properly (I think both Excel and LibreOffice support it at least).

Array notations are staying unchanged because that's how most of the world does it.

Only 3 DBCs changed in 28807 so only those will show up on the site with that build. Other DBCs should all show their latest version.

Rokeo commented 5 years ago

Can you add ability to export all databases in bulk for last build?

I.e. i have chosen 28807 build and want to download all which changed at this build. it is very inconvinent to search and select one by one.

It will be also nice to have ability download all lastest databased for last retail build in builk.

p.s. i didn't found in select list ability to select 28807 build, but saw it in main page, it is not added yet?

Thank you!

Marlamin commented 5 years ago

It only lists versions where DBCs actually changed, so for some of the manifest DBCs 28807 will show up. Other DBCs were last changed in older builds so 28807 won't be listed. I'm not sure I want to add bulk export due to the added load that comes with that. Will have to think that over.

Rokeo commented 5 years ago

it is just very time consuming to search for each database, select it, select retail build if you want to expost many of those, thats why i asked for convinient option to do such, hope you could implement it! :)

Marlamin commented 5 years ago

Understandable, but I'm not sure I want people building things relying on bulk exports. :)