Weird gaps between subchunks in dungeon maps

Marlamin / WoWFormatTest

Several applications that I use to interact with various file formats WoW uses

https://wow.tools

MIT License

69 stars 19 forks source link

Weird gaps between subchunks in dungeon maps #95

Closed Rokeo closed 5 years ago

Rokeo commented 5 years ago

Hi, Marlamin! Not really an issue, but more a question. I tried recently to export dungeon maps from Bfa and got weird result - tile map visally have small gaps inside (i guess they formed when subchunks were merged), didn't experienced anything like this on continent maps, including Bfa, before. Is there something special about dungeon maps, which should be taken in consideration? or do you have any clue why can this happen and how to fix this?

Thanks!

p.s as example, i tried to export freehold dungeon map

Marlamin commented 5 years ago

This should either be happening for all maps or for none as there is (afaik) no difference in the way these are generated. Can you go closer up to see how big the gap is?

Rokeo commented 5 years ago

piratetowndungeon_31_34.zip Here is example of such tile. For some reason i encountered this only when tried to export map for dungeons, so i thought maybe i do not know something which i should consider... So i do not ever have clue why this could occure.

Thanks!

Rokeo commented 5 years ago

Counting that objects are on such gaps, i think this is from adt terrain itself (chunks somehow didn't connected properly?) In image you can see small rock right above such gap

Marlamin commented 5 years ago

Yeah, it exports chunks chunk by chunk and doesn't do anything to connect them as I always thought these were directly adjacent. I guess I might have to do some connecting anyways.

Rokeo commented 5 years ago

If you found any workaound for this, please post about it! Would be greatful, thanks! For continent maps i think it is the case - as i didn't saw this before, but for dungeons, not sure why is that. I also thought those should be adjasted to each other.

Marlamin commented 5 years ago

Can you upload the obj file that is exported? The one you uploaded seems to be re-exported from something else.

Rokeo commented 5 years ago

I will try to make it with tool itself, i use parts of your code, but it ends up in project made by me, so yea, thats why it do not have headers from OBJExporter

Marlamin commented 5 years ago

Yeah, please do.

Rokeo commented 5 years ago

I seems to be found issue, it was due to CultureInfo, which cause in my files to save coords with coma and not dot separator, like: v -1254,436 38,69772 -2230,533 instead of v -1254.436 38.69772 -2230.533

Which was causing this confusion and gaps at the end.

Sorry for bothering you!

p.s. hate this issues with cultureinfo and numbers formats! p.p.s i can swear before some VS update those were dots always and never comma!

Marlamin commented 5 years ago

No problem, CultureInfo is indeed a bitch. Differs per computer.