MarlinFirmware / Configurations

Configurations for Marlin Firmware
https://marlinfw.org
GNU General Public License v3.0
1.98k stars 3.33k forks source link

Add CR-10S with BTT SKR Mini E3 3.0, Ender3 V2 with BTT SKR Mini E3 2.0, Ender3 V2 with creality v4.2.7 #1031

Closed ellensp closed 1 month ago

ellensp commented 3 months ago

Requirements

Users requested these in "[FR] Configurations for all 3D printers and every possible permutation"

CR-10S with BTT SKR Mini E3 3.0 Ender3 V2 with BTT SKR Mini E3 2.0 Ender3 V2 with creality v4.2.7

Description

added CR-10S BTT SKR Mini E3 3.0 configs addee E3V2 BTT SKR Mini E3 2.0 configs added E3V2 creality v4.2.7 configs

Benefits

More common printer and motherboard combinations

Related Issues

https://github.com/MarlinFirmware/Configurations/issues/649

NOTE

All untested beyond building. These where trivial changes from existing example configs

ellensp commented 3 months ago

Error is deliberate to ensure user knows they need a custom display cable

thisiskeithb commented 3 months ago

Error is deliberate to ensure user knows they need a custom display cable

The CI test could be updated here to skip fatal warnings like we do for the build_example script:

# Suppress fatal warnings
echo -e "\n#define NO_CONTROLLER_CUSTOM_WIRING_WARNING" >> Marlin/Configuration.h

This is especially true for future ambitions to automatically build configs in regular intervals and eventually automate config releases when there’s a new tag upstream.

Also, adding the disabled defines in 8b9e592 doesn’t seem necessary.

ellensp commented 3 months ago

"Also, adding the disabled defines in https://github.com/MarlinFirmware/Configurations/commit/8b9e59247bb8c6d73f790971524a82e800b6e221 doesn’t seem necessary."

Its to stop uses going I cant find it.. now its right there in their faces.

thisiskeithb commented 3 months ago

Its to stop uses going I cant find it.. now its right there in their faces.

Now we have another place to remember to update if the name changes since it’s not included as a config item / in all configs by default.