MarlinFirmware / Configurations

Configurations for Marlin Firmware
https://marlinfw.org
GNU General Public License v3.0
1.98k stars 3.33k forks source link

šŸ”§ FlashForge Creator Pro updates #1047

Closed queengooborg closed 1 month ago

queengooborg commented 2 months ago

Description

This PR updates the configuration data for the FlashForge Creator Pro, following issues I ran into during my own work modding my FFCP. This performs the following updates:

Benefits

Benefits stated in description!

queengooborg commented 2 months ago

Since changes are combined in this PR now, let me make a few more nice-to-have tweaks real quick!

queengooborg commented 2 months ago

All set now!

thisiskeithb commented 2 months ago

Fixes the left extruder's direction (I found that it is reversed)

Were both extruder directions incorrect? I'm curious why no one has run into this issue before. Also, you updated E0 and E2 (I think you meant to update E1 here).

queengooborg commented 2 months ago

Just the one extruder motor -- I'm kind of surprised that no one else caught this, since the extruder motors need to spin in opposite directions from each other due to the way they grab the filament. Maybe I'm the first to do a Marlin mod and try to use both extruders! šŸ˜†

Its also very possible that the connector to the stepper driver was flipped by the manufacturer, and when I put my own printer back together, I un-flipped it. Happy to revert if so!


Regarding E0, that was accidental (I flipped that boolean in my own configuration while working on a mod to make my left extruder the first extruder), but it doesn't seem to have any effect. Happy to revert that as well!

thisiskeithb commented 2 months ago

There is no E2, only E0 and E1 (zero-based), so changing INVERT_E2_DIR doesn't actually do anything.

Regarding E0, that was accidental [...], but it doesn't seem to have any effect

Please push another commit that fixes the correct extruder behavior & reverts the change to the unaffected extruder.

queengooborg commented 2 months ago

It actually did make a difference on my setup, even before applying left-extruder-is-first modding. I'm a bit too far into that to go back and test without it, so I've just reverted the changes!

thisiskeithb commented 2 months ago

It actually did make a difference on my setup

That wouldn't be possible unless you're running three extruders: E0, E1, and E2.

Also, from https://github.com/MarlinFirmware/Marlin/pull/12855:

Dual extrusion worked right on Simplify and the CreatorPro

So maybe there is something different about your printer?

queengooborg commented 2 months ago

Unless I somehow got a non-standard unit from Amazon, there shouldn't have been anything different!

Maybe I changed some other variable besides the E2 variable and hadn't realized it?

Edit: okay, I just looked at my change history, and yes, it looks like I did change E0 when doing those tests and didn't realize it. Whoops!

queengooborg commented 2 months ago

I've pushed a bunch more updates to get the FFCP configuration working as desirably as possible -- some of them may be more of a personal preference than others (ex. the job start chime), but I feel all the changes are helpful!

queengooborg commented 1 month ago

Thanks for merging! I feel embarrassed with how many typos there were in the documentation, haha...!