MarlinFirmware / Configurations

Configurations for Marlin Firmware
https://marlinfw.org
GNU General Public License v3.0
1.98k stars 3.33k forks source link

🩹 Fix Formbot T-Rex 2+ X2 max position #1056

Closed thisiskeithb closed 1 week ago

thisiskeithb commented 1 month ago

Description

While running the build_all_examples script, this config would not build:

In file included from Marlin/src/HAL/AVR/../../inc/MarlinConfigPre.h:56:0,
                 from Marlin/src/HAL/AVR/../../inc/MarlinConfig.h:28,
                 from Marlin/src/HAL/AVR/HAL.cpp:24:
Marlin/src/HAL/AVR/../../inc/../../Configuration_adv.h:823:24: error: floating constant in preprocessor expression
   #define X2_MAX_POS   434.6      // The max position of the X2 carriage, typically also the home position
                        ^

Rounding X2_MAX_POS down to 434 prevents the error and allows the config to build.

Benefits

Config now builds.

Related Issues

thisiskeithb commented 1 month ago

Talking with @InsanityAutomation, he says that we need to allow floats in MIN/MAX positions for proper IDEX operation, so that will need to get fixed upstream.

thisiskeithb commented 1 week ago

Apparently these TREX configs are very broken according to @InsanityAutomation, so I'll just close this for now as they won't work anyway.