search

MarlinFirmware / Configurations

Configurations for Marlin Firmware
https://marlinfw.org
GNU General Public License v3.0
1.98k stars 3.33k forks source link

Compile error SDSUPPORT Artillery Ruby #1059

Closed pmanzionna closed 1 month ago

pmanzionna commented 1 month ago

Did you test the latest bugfix-2.1.x code?

No, but I will test it now!

Bug Description

Cattura

Bug Timeline

New bug with Marlin 2.1.2.3

Expected behavior

Compile error

Actual behavior

No response

Steps to Reproduce

No response

Version of Marlin Firmware

2.1.2.3

Printer model

Artillry Hornet

Electronics

Artillery_ruby

LCD/Controller

No response

Other add-ons

No response

Bed Leveling

None

Your Slicer

None

Host Software

None

Don't forget to include

Additional information & file uploads

No response

pmanzionna commented 1 month ago

official config/examples/Artillery/Hornet files

ellensp commented 1 month ago

this is a bug in the configs

elif SDSUPPORT should be #elif ENABLED(SDSUPPORT)

pmanzionna commented 1 month ago

Thank you ellensp... it works!

ellensp commented 1 month ago

I think it was meant to be #elif HAS_MEDIA but that needs testing

pmanzionna commented 1 month ago

Tested with #elif HAS_MEDIA... it seems to work.

thisiskeithb commented 1 month ago

I opened a PR with fixes in https://github.com/MarlinFirmware/Configurations/pull/1060, but thinkyhead directly committed them instead of merging my PR so this issue was not auto-closed.

Closing as resolved.